Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
L
liblongpath-rsync
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
liblongpath
liblongpath-rsync
Commits
41979f25
Commit
41979f25
authored
Nov 05, 2007
by
Wayne Davison
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make sure that get_xattr_data() never tries to malloc 0 bytes.
parent
4b1553e2
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
4 deletions
+7
-4
xattrs.c
xattrs.c
+7
-4
No files found.
xattrs.c
View file @
41979f25
...
@@ -161,8 +161,11 @@ static char *get_xattr_data(const char *fname, const char *name, size_t *len_ptr
...
@@ -161,8 +161,11 @@ static char *get_xattr_data(const char *fname, const char *name, size_t *len_ptr
int
no_missing_error
)
int
no_missing_error
)
{
{
size_t
datum_len
=
sys_lgetxattr
(
fname
,
name
,
NULL
,
0
);
size_t
datum_len
=
sys_lgetxattr
(
fname
,
name
,
NULL
,
0
);
size_t
extra_len
=
*
len_ptr
;
char
*
ptr
;
char
*
ptr
;
*
len_ptr
=
datum_len
;
if
(
datum_len
==
(
size_t
)
-
1
)
{
if
(
datum_len
==
(
size_t
)
-
1
)
{
if
(
errno
==
ENOTSUP
||
no_missing_error
)
if
(
errno
==
ENOTSUP
||
no_missing_error
)
return
NULL
;
return
NULL
;
...
@@ -172,12 +175,12 @@ static char *get_xattr_data(const char *fname, const char *name, size_t *len_ptr
...
@@ -172,12 +175,12 @@ static char *get_xattr_data(const char *fname, const char *name, size_t *len_ptr
return
NULL
;
return
NULL
;
}
}
if
(
datum_len
+
*
len_ptr
<
datum_len
/* checks for overflow */
if
(
!
datum_len
&&
!
extra_len
)
||
!
(
ptr
=
new_array
(
char
,
datum_len
+
*
len_ptr
)))
extra_len
=
1
;
/* request non-zero amount of memory */
if
(
datum_len
+
extra_len
<
datum_len
/* checks for overflow */
||
!
(
ptr
=
new_array
(
char
,
datum_len
+
extra_len
)))
out_of_memory
(
"get_xattr_data"
);
out_of_memory
(
"get_xattr_data"
);
*
len_ptr
=
datum_len
;
if
(
datum_len
)
{
if
(
datum_len
)
{
size_t
len
=
sys_lgetxattr
(
fname
,
name
,
ptr
,
datum_len
);
size_t
len
=
sys_lgetxattr
(
fname
,
name
,
ptr
,
datum_len
);
if
(
len
!=
datum_len
)
{
if
(
len
!=
datum_len
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment