• Andreas Rheinhardt's avatar
    avformat/id3v2: Don't reverse the order of id3v2 APICs · 8068f2fc
    Andreas Rheinhardt authored
    When parsing ID3v2 tags, special (non-text) metadata is not applied
    directly and unconditionally; instead it is stored in a linked list
    in which elements are prepended. When traversing the list to add APICs
    (or private tags) at the end, the order is reversed. The same also
    happens for chapters and therefore the chapter parsing code already
    reverses the chapters.
    
    This commit changes this: By keeping pointers to both head and tail
    of the linked list one can preserve the order of the entries and
    remove the reordering code for chapters. Only the pointer to head
    will be exported: No current caller uses a nonempty list, so exporting
    both head and tail is unnecessary. This removes the functionality
    to combine the lists of special metadata read from different ID3v2 tags,
    but that doesn't make really much sense anyway (and would be trivial
    to implement if desired) and allows to remove the now unnecessary
    initializations performed by the callers.
    
    The FATE-reference for the id3v2-priv test had to be updated
    because the order of the tags read into the dict is reversed;
    for id3v2-priv-remux only the md5 and not the ffprobe output
    of the remuxed file changes because the order of the private tags
    has up until now been reversed twice.
    
    The references for the aiff/mp3 cover-art tests needed to be updated,
    because the order of the attached pics is reversed upon reading.
    It is still not correct, because the muxers write the pics in the order
    in which they arrive at the muxer instead of the order given by
    pkt->stream_index.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@outlook.com>
    8068f2fc
asf.c 9.59 KB