• Andreas Rheinhardt's avatar
    avformat/oggparsevorbis: Avoid tmp bufs when parsing VorbisComment · b10a8a30
    Andreas Rheinhardt authored
    A single VorbisComment consists of a length field and a
    non-NUL-terminated string of the form "key=value". Up until now,
    when parsing such a VorbisComment, zero-terminated duplicates of
    key and value would be created. This is wasteful if these duplicates
    are freed shortly afterwards, as happens in particular in case of
    attached pictures: In this case value is base64 encoded and only
    needed to decode the actual data.
    
    Therefore this commit changes this: The buffer is temporarily modified
    so that both key and value are zero-terminated. Then the data is used
    in-place and restored to its original state afterwards.
    
    This requires that the buffer has at least one byte of padding. All
    buffers currently have AV_INPUT_BUFFER_PADDING_SIZE bytes padding,
    so this is ok.
    
    Finally, this also fixes weird behaviour from ogm_chapter():
    It sometimes freed given to it, leaving the caller with dangling
    pointers.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@outlook.com>
    b10a8a30
oggdec.h 6.06 KB