• Martin Storsjö's avatar
    seek: Fix crashes in ff_seek_frame_binary if built with latest Clang 14 · ab792634
    Martin Storsjö authored
    Passing an uninitialized variable as argument to a function is
    undefined behaviour (UB). The compiler can assume that UB does not
    happen.
    
    Hence, the compiler can assume that the variables are never
    uninitialized when passed as argument, which means that the codepaths
    that initializes them must be taken.
    
    In ff_seek_frame_binary, this means that the compiler can assume
    that the codepaths that initialize pos_min and pos_max are taken,
    which means that the conditions "if (sti->index_entries)" and
    "if (index >= 0)" can be optimized out.
    
    Current Clang git versions (upcoming Clang 14) enabled an optimization
    that does this, which broke the current version of this function
    (which intentionally left the variables uninitialized, but silencing
    warnings about being uninitialized). See [1] for discussion on
    the matter.
    
    [1] https://reviews.llvm.org/D105169#3069555Signed-off-by: 's avatarMartin Storsjö <martin@martin.st>
    ab792634
seek.c 24.8 KB