Retire the undocumented .debug() method.

We can now use the benchmarks to dump data structures. This can be
done for both QP and PH, and is not limited by workspace or the
varnishtest log buffer.

README.rst

@@ -845,13 +845,6 @@ Example::
   # /foo/bar/1/2/* is rewritten as /foo/bar/2/1/*
   # /foo/bar/baz/1/2/* is rewritten as /foo/bar/baz/2/1/*
 
-.. _xset.debug():
-
-STRING xset.debug()
--------------------
-
-Intentionally not documented.
-
 .. _selector.version():
 
 STRING version()

src/tests/case.vtc

@@ -818,7 +818,6 @@ varnish v1 -vcl {
 		set resp.http.Matched-2 = s.matched(2);
 		set resp.http.Matched-3 = s.matched(3);
 		set resp.http.Matched-4 = s.matched(4);
-		set resp.body = s.debug();
 		return (deliver);
 	}
 }

src/tests/match.vtc

@@ -31,7 +31,6 @@ varnish v1 -vcl {
 		set resp.http.Match-Zab = t.match("zab");
 		set resp.http.Match-Xuuq = t.match("xuuq");
 		set resp.http.Match-Raboof = t.match("raboof");
-		set resp.body = t.debug();
 		return (deliver);
 	}
 } -start
@@ -72,7 +71,6 @@ varnish v1 -vcl {
 		set resp.http.Which-Etude = t.which();
 		set resp.http.Match-Etudes = t.match("études");
 		set resp.http.Which-Etudes = t.which();
-		set resp.body = t.debug();
 		return (deliver);
 	}
 }

src/tests/prefix.vtc

@@ -30,7 +30,6 @@ varnish v1 -vcl {
 		set resp.http.Matched-2 = s.matched(2);
 		set resp.http.Matched-3 = s.matched(3);
 		set resp.http.Matched-4 = s.matched(4);
-		set resp.body = s.debug();
 		return (deliver);
 	}
 } -start
@@ -174,7 +173,6 @@ varnish v1 -vcl {
 		set resp.http.Matched-2 = s.matched(2);
 		set resp.http.Matched-3 = s.matched(3);
 		set resp.http.Matched-4 = s.matched(4);
-		set resp.body = s.debug();
 		return (deliver);
 	}
 }
@@ -354,7 +352,6 @@ varnish v1 -vcl {
 		set resp.http.Matched-2 = s.matched(2);
 		set resp.http.Matched-3 = s.matched(3);
 		set resp.http.Matched-4 = s.matched(4);
-		set resp.body = s.debug();
 		return (deliver);
 	}
 }

src/vmod_selector.c

@@ -842,24 +842,6 @@ vmod_set_sub(VRT_CTX, struct vmod_selector_set *set, VCL_STRING str,
 	return (VRT_regsub(ctx, all, str, re, sub));
 }
 
-VCL_STRING
-vmod_set_debug(VRT_CTX, struct vmod_selector_set *set)
-{
-	struct vsb *sb;
-	VCL_STRING output;
-
-	CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC);
-	CHECK_OBJ_NOTNULL(set, VMOD_SELECTOR_SET_MAGIC);
-
-	sb = QP_Dump(set->origo, set->members);
-	CHECK_OBJ_NOTNULL(sb, VSB_MAGIC);
-	output = WS_Copy(ctx->ws, VSB_data(sb), -1);
-	VSB_destroy(&sb);
-	if (output == NULL)
-		VFAIL(ctx, "%s.debug(): out of workspace", set->vcl_name);
-	return output;
-}
-
 VCL_VOID
 vmod_set_create_stats(VRT_CTX, struct vmod_selector_set *set,
 		      struct vmod_priv *priv)

src/vmod_selector.vcc

@@ -736,10 +736,6 @@ Example::
   # /foo/bar/1/2/* is rewritten as /foo/bar/2/1/*
   # /foo/bar/baz/1/2/* is rewritten as /foo/bar/baz/2/1/*
 
-$Method STRING .debug()
-
-Intentionally not documented.
-
 $Function STRING version()
 
 Return the version string for this VMOD.