Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
S
slash
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
uplex-varnish
slash
Commits
d38d3901
Unverified
Commit
d38d3901
authored
Feb 02, 2024
by
Nils Goroll
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fellow_storage: Clarify error handling for _getspace()
parent
2de8497c
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
1 deletion
+16
-1
fellow_storage.c
src/fellow_storage.c
+8
-1
fellow_coverage.vtc
src/vtc/fellow_coverage.vtc
+8
-0
No files found.
src/fellow_storage.c
View file @
d38d3901
...
@@ -969,7 +969,14 @@ sfemem_getspace(struct worker *wrk, struct objcore *oc, ssize_t *ssz,
...
@@ -969,7 +969,14 @@ sfemem_getspace(struct worker *wrk, struct objcore *oc, ssize_t *ssz,
out:
out:
#endif
#endif
if
(
fcr
.
status
!=
fcr_ok
)
{
if
(
fcr
.
status
!=
fcr_ok
)
{
VSLb
(
wrk
->
vsl
,
SLT_Error
,
"GetSpace: %s"
,
/*
* XXX can not fail the oc here:
* Assert error in vbf_fetch_thread(), cache/cache_fetch.c line 1124:
* Condition((oc->flags & OC_F_FAILED) == 0) not true.
*/
//XXX oc_fcr_handle(wrk, oc, fcr);
VSLb
(
wrk
->
vsl
,
SLT_Error
,
"fellow %s: %s"
,
fellow_cache_res_s
[
fcr
.
status
],
fcr
.
r
.
err
?
fcr
.
r
.
err
:
"Unknown error"
);
fcr
.
r
.
err
?
fcr
.
r
.
err
:
"Unknown error"
);
*
ssz
=
-
1
;
*
ssz
=
-
1
;
return
(
0
);
return
(
0
);
...
...
src/vtc/fellow_coverage.vtc
View file @
d38d3901
...
@@ -43,6 +43,13 @@ varnish v1 -vcl+backend {
...
@@ -43,6 +43,13 @@ varnish v1 -vcl+backend {
}
}
}
}
logexpect l1 -v v1 -g vxid -q {BereqURL ~ "^/256k.1"} {
fail add * End
expect * * Error "objsize_max reached"
expect 0 = FetchError "Could not get storage"
fail clear
} -start
client c1 {
client c1 {
txreq -url "/256k"
txreq -url "/256k"
rxresp
rxresp
...
@@ -70,6 +77,7 @@ client c2 {
...
@@ -70,6 +77,7 @@ client c2 {
client c1 -wait
client c1 -wait
client c2 -wait
client c2 -wait
server s1 -wait
server s1 -wait
logexpect l1 -wait
server s1 {
server s1 {
rxreq
rxreq
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment