Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
varnish-cache
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Commits
Open sidebar
varnishcache
varnish-cache
Commits
a54af587
Commit
a54af587
authored
Jan 10, 2013
by
Poul-Henning Kamp
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
A quick FlexeLint check to see that there are no major complaints
parent
703e7e67
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
19 additions
and
19 deletions
+19
-19
flint.lnt
bin/flint.lnt
+7
-0
flint.lnt
bin/varnishd/flint.lnt
+0
-3
flint.lnt
bin/varnishlog/flint.lnt
+1
-1
varnishlog.c
bin/varnishlog/varnishlog.c
+5
-5
base64.c
bin/varnishncsa/base64.c
+2
-4
varnishncsa.c
bin/varnishncsa/varnishncsa.c
+4
-6
No files found.
bin/flint.lnt
View file @
a54af587
...
...
@@ -103,3 +103,10 @@
-elib(123) // macro def. with arg at, (just warn)
-emacro(702, WEXITSTATUS) // signed shift right
-e786 // String concatenation within initializer
-e726 // Extraneous comma ignored
-e825 // control flows into case/default without -fallthrough comment
-e835 // A zero has been given as ___ argument to operator '___' (<<)
bin/varnishd/flint.lnt
View file @
a54af587
...
...
@@ -77,7 +77,6 @@
-e459 // unlocked access from func-ptr
-e454 // mutex not released (...ReleaseLocked)
-e457 // unprotected access
-e835 // A zero has been given as ___ argument to operator '___' (<<)
-e777 // float equality comparison
-e679 // Suspicious Truncation in arithmetic expression combining with pointer
...
...
@@ -130,11 +129,9 @@
-e455 // thread lock
-e458 // unprotected read
-e763 // Redundant declaration for symbol '...' previously declared
-e726 // Extraneous comma ignored
-e728 // Symbol ... not explicitly initialized
-e716 // while(1) ...
-e785 // Too few initializers for aggregate
-e786 // String concatenation within initializer
-esym(765, vcc_ProcAction) // could be made static
-esym(759, vcc_ProcAction) // could be moved to module
...
...
bin/varnishlog/flint.lnt
View file @
a54af587
...
...
@@ -18,4 +18,4 @@
-e788 // enum constant '___' not used within defaulted switch
-e641 // Converting enum '___' to '___'
-esym(785,VSL_tags)
;
// Sparse array
-esym(785,VSL_tags) // Sparse array
bin/varnishlog/varnishlog.c
View file @
a54af587
...
...
@@ -128,7 +128,7 @@ h_order(void *priv, enum VSL_tag_e tag, unsigned fd, unsigned len,
* starting on the new one.
*/
if
(
last
[
fd
]
!=
SLT_SessClose
)
VSB_printf
(
ob
[
fd
],
"%5
d
%-12s %c %s
\n
"
,
VSB_printf
(
ob
[
fd
],
"%5
u
%-12s %c %s
\n
"
,
fd
,
"Interrupted"
,
type
,
VSL_tags
[
tag
]);
h_order_finish
(
fd
,
vd
);
}
...
...
@@ -141,8 +141,8 @@ h_order(void *priv, enum VSL_tag_e tag, unsigned fd, unsigned len,
VSB_cat
(
ob
[
fd
],
"
\n
"
);
else
flg
[
fd
]
|=
F_INVCL
;
VSB_printf
(
ob
[
fd
],
"%5
d
%-12s %c %.*s"
,
fd
,
VSL_tags
[
tag
],
type
,
len
,
ptr
);
VSB_printf
(
ob
[
fd
],
"%5
u
%-12s %c %.*s"
,
fd
,
VSL_tags
[
tag
],
type
,
(
int
)
len
,
ptr
);
return
(
0
);
case
SLT_VCL_trace
:
case
SLT_VCL_return
:
...
...
@@ -159,8 +159,8 @@ h_order(void *priv, enum VSL_tag_e tag, unsigned fd, unsigned len,
VSB_cat
(
ob
[
fd
],
"
\n
"
);
flg
[
fd
]
&=
~
F_INVCL
;
}
VSB_printf
(
ob
[
fd
],
"%5
d
%-12s %c %.*s
\n
"
,
fd
,
VSL_tags
[
tag
],
type
,
len
,
ptr
);
VSB_printf
(
ob
[
fd
],
"%5
u
%-12s %c %.*s
\n
"
,
fd
,
VSL_tags
[
tag
],
type
,
(
int
)
len
,
ptr
);
switch
(
tag
)
{
case
SLT_ReqEnd
:
case
SLT_BackendClose
:
...
...
bin/varnishncsa/base64.c
View file @
a54af587
...
...
@@ -6,10 +6,6 @@
#include "config.h"
#include <sys/types.h>
#include <stdio.h> // for test-prog
#include "base64.h"
static
const
char
b64
[]
=
...
...
@@ -63,6 +59,8 @@ VB64_decode(char *d, unsigned dlen, const char *s)
#ifdef TEST_DRIVER
#include <stdio.h> // for test-prog
const
char
*
test1
=
"TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IGhpcyByZWFzb24sIGJ1dCBieSB0aGlz"
"IHNpbmd1bGFyIHBhc3Npb24gZnJvbSBvdGhlciBhbmltYWxzLCB3aGljaCBpcyBhIGx1c3Qgb2Yg"
...
...
bin/varnishncsa/varnishncsa.c
View file @
a54af587
...
...
@@ -77,7 +77,6 @@
#include "vcs.h"
#include "vpf.h"
#include "vqueue.h"
#include "vre.h"
#include "vsb.h"
#include "compat/daemon.h"
...
...
@@ -112,7 +111,7 @@ static struct logline {
VTAILQ_HEAD
(,
hdr
)
vcl_log
;
/* VLC_Log entries */
}
**
ll
;
struct
VSM_data
*
vd
;
st
atic
st
ruct
VSM_data
*
vd
;
static
size_t
nll
;
...
...
@@ -210,7 +209,6 @@ req_header(struct logline *l, const char *name)
VTAILQ_FOREACH
(
h
,
&
l
->
req_headers
,
list
)
{
if
(
strcasecmp
(
h
->
key
,
name
)
==
0
)
{
return
(
h
->
value
);
break
;
}
}
return
(
NULL
);
...
...
@@ -223,7 +221,6 @@ resp_header(struct logline *l, const char *name)
VTAILQ_FOREACH
(
h
,
&
l
->
resp_headers
,
list
)
{
if
(
strcasecmp
(
h
->
key
,
name
)
==
0
)
{
return
(
h
->
value
);
break
;
}
}
return
(
NULL
);
...
...
@@ -236,7 +233,6 @@ vcl_log(struct logline *l, const char *name)
VTAILQ_FOREACH
(
h
,
&
l
->
vcl_log
,
list
)
{
if
(
strcasecmp
(
h
->
key
,
name
)
==
0
)
{
return
(
h
->
value
);
break
;
}
}
return
(
NULL
);
...
...
@@ -796,6 +792,7 @@ h_ncsa(void *priv, enum VSL_tag_e tag, unsigned fd,
p
=
tmp
;
break
;
}
/* FALLTHROUGH */
default:
fprintf
(
stderr
,
"Unknown format starting at: %s
\n
"
,
--
p
);
...
...
@@ -923,7 +920,8 @@ main(int argc, char *argv[])
/* XXX: Silently ignored: it's required anyway */
break
;
case
'm'
:
m_flag
=
1
;
/* Fall through */
m_flag
=
1
;
/* FALLTHOUGH */
default:
if
(
VSL_Arg
(
vd
,
c
,
optarg
)
>
0
)
break
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment