- 19 Nov, 2021 2 commits
-
-
Poul-Henning Kamp authored
-
Nils Goroll authored
When decoding only a substring, we naturally see no padding, so we must not base tail processing on the number of pad characters seen, but rather on the number of characters missing until the end of the current block of four. Fixes #3378
-
- 12 Nov, 2021 4 commits
-
-
Martin Blix Grydeland authored
-
Guillaume Quintard authored
Conflicts: .travis.yml bin/varnishd/cache/cache_panic.c
-
Dridi Boukelmoune authored
When a VUT is slow enough, it might very well be overrun while it is scanning logs. For our built-in VUTs like varnishncsa or varnishlog this can happen if writing the output can block waiting for IO ops or when the output is piped to a slow consumer.
-
Dridi Boukelmoune authored
There's only one call site for vtx_dispatch() and it guarantees that len is greater than zero.
-
- 10 Nov, 2021 3 commits
-
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
-
- 09 Nov, 2021 3 commits
-
-
Martin Blix Grydeland authored
-
Pål Hermunn Johansen authored
A default stack space of 48k will cause a stack overflow in some of the test cases on some Linux distributions. The increase to 64k seems to be enough to solve this.
-
Emanuele Rocca authored
Fixes #3437
-
- 25 Oct, 2021 3 commits
-
-
Nils Goroll authored
0051cbe3 did not work on solaris-descendents, the man page clearly states that the size argument also determines the buffer to be malloc()ed for a NULL buffer argument.
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
Ever since my system upgraded haproxy to 2.3.10 this test has consistently timed out. While that would be a breaking change involving the independent vtest project too, I think the VTC syslog spec would work better with something like: expect skip facility.level regex Where skip could be uint, * or ? similar to how logexpect works, and both facility and level could also be * to be non-specific. For now, let's hope this does not break the test suite for anyone else. Conflicts: bin/varnishtest/tests/h00005.vtc
-
- 20 Aug, 2021 1 commit
-
-
Dridi Boukelmoune authored
In the output of vcl.show -v, it means that the least useful file (in the sense that it is common to every single vcl.load) is now printed last. This change originates from a larger and more intrusive refactoring. It also helps get rid of spurious Wstring-contatenation warnings from clang 12 in the test suite, instead of disabling it altogether. Refs c8174af6
-
- 11 Aug, 2021 1 commit
-
-
Reza Naghibi authored
Conflicts: bin/varnishd/cache/cache_esi_deliver.c
-
- 03 Aug, 2021 1 commit
-
-
Dridi Boukelmoune authored
This is just the order of their declaration in the VCL manual. As a side effect it works around a bug where the sess.xid syntax requirements would prevent sess.timeout_idle to be used in VCL 4.0, which is less intrusive than a proper fix. The bug was fixed in trunk without being noticed in the first place after many heavy changes to libvcc. For a stable branch this is less risky than a back-port since there are only two sess.* symbols. Fixes #3564
-
- 01 Jul, 2021 5 commits
-
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
When receiving H/2 data frames, make sure to take the advertised content length into account, and fail appropriately if the combined sum of the data frames does not match the content length.
-
Martin Blix Grydeland authored
The change to VTCP_Check() in 58a21da7 broke expect_close in varnishtest.
-
- 28 Apr, 2021 5 commits
-
-
Dridi Boukelmoune authored
Technically it can also happen with a debugger attached to a process despite SA_RESTART.
-
Dridi Boukelmoune authored
Conflicts: lib/libvarnish/binary_heap.c
-
Nils Goroll authored
... documented on Linux as POSIX.1 The exception here is ECONNREFUSED which so far we only tolerate for Solaris and which seems to make sense for connect() only. To be discussed in #3539
-
Nils Goroll authored
Conflicts: lib/libvarnish/vtcp.c
-
Nils Goroll authored
it was already accepted on Solaris and NetBSD, now we have seen it on Linux and I think it does not make sense to keep the exception for Apple. Fixes #3532 (hopefully) Conflicts: lib/libvarnish/vtcp.c
-
- 23 Apr, 2021 1 commit
-
-
Reza Naghibi authored
-
- 22 Apr, 2021 7 commits
-
-
Martin Blix Grydeland authored
This adds VTCP_Assert() on the result of read and write calls that deals with TCP sockets. Conflicts: bin/varnishd/proxy/cache_proxy_proto.c
-
Martin Blix Grydeland authored
-
Martin Blix Grydeland authored
When used to check the result of read() and write() calls, it is useful that a positive return value is accepted in VTCP_Check().
-
Martin Blix Grydeland authored
Now that VTCP_Assert() accepts EAGAIN as a legal errno value for read() errors, uncomment this check.
-
Martin Blix Grydeland authored
Since the input value is sometimes the result of a read()/write() call, avoid truncating the ssize_t value on calling it.
-
Martin Blix Grydeland authored
When a socket timeout is set on a socket and the timeout expires, read() and write() calls on that socket will return (-1) with errno set to EAGAIN/EWOULDBLOCK. Conflicts: lib/libvarnish/vtcp.c
-
Martin Blix Grydeland authored
Consistently use VTCP_Assert when asserting on the result of VTCP_Check().
-
- 21 Apr, 2021 4 commits
-
-
Martin Blix Grydeland authored
Once HSH_Unbusy() has been called there is a possibility for EXP_Remove() to be called before the fetch thread has had a chance to call EXP_Insert(). By adding a OC_EF_NEW flag on the objects during HSH_Unbusy(), that is removed again during EXP_Insert(), we can keep track and clean up once EXP_Insert() is called by the inserting thread if EXP_Remove() was called in the mean time. This patch also removes the AZ(OC_F_DYING) in EXP_Insert(), as that is no longer a requirement. Fixes: #2999
-
Martin Blix Grydeland authored
This makes the order of events the same as on real cache insertions.
-
Martin Blix Grydeland authored
The OC_EF_REFD flag indicates whether expiry has a ref on the OC. Previously, the flag was only gained during the call to EXP_Insert. With this patch, and the helper function EXP_RefNewObjcore(), the flag is gained while holding the objhead mutex during HSH_Unbusy(). This enables the expiry functions to test on missing OC_EF_REFD and quickly return without having to take the main expiry mutex. Conflicts: bin/varnishd/cache/cache_varnishd.h
-
Martin Blix Grydeland authored
When posting to the expiry thread, we wrongly counted exp_mailed also if the OC in question was already on the mail queue. This could cause a discrepency between the exp_mailed and exp_received counters.
-