Commit 09b7f5db authored by Andrew Tridgell's avatar Andrew Tridgell

move the read only daemon test to after the protocol setup

parent 6d7b6081
...@@ -101,8 +101,10 @@ int start_socket_client(char *host, char *path, int argc, char *argv[]) ...@@ -101,8 +101,10 @@ int start_socket_client(char *host, char *path, int argc, char *argv[])
} }
io_printf(fd,"\n"); io_printf(fd,"\n");
if (remote_version == 22 || (remote_version > 17 && !am_sender)) if (remote_version < 23) {
io_start_multiplex_in(fd); if (remote_version == 22 || (remote_version > 17 && !am_sender))
io_start_multiplex_in(fd);
}
return client_run(fd, fd, -1, argc, argv); return client_run(fd, fd, -1, argc, argv);
} }
...@@ -163,9 +165,6 @@ static int rsync_module(int fd, int i) ...@@ -163,9 +165,6 @@ static int rsync_module(int fd, int i)
module_id = i; module_id = i;
if (lp_read_only(i))
read_only = 1;
am_root = (getuid() == 0); am_root = (getuid() == 0);
if (am_root) { if (am_root) {
...@@ -316,15 +315,9 @@ static int rsync_module(int fd, int i) ...@@ -316,15 +315,9 @@ static int rsync_module(int fd, int i)
argp = argv + optind; argp = argv + optind;
optind = 0; optind = 0;
if (remote_version == 22 || (remote_version > 17 && am_sender)) if (remote_version < 23) {
io_start_multiplex_out(fd); if (remote_version == 22 || (remote_version > 17 && am_sender))
io_start_multiplex_out(fd);
if (read_only) {
extern int am_sender;
if (!am_sender) {
rprintf(FERROR,"ERROR: module is read only\n");
return -1;
}
} }
if (!ret) { if (!ret) {
......
...@@ -350,9 +350,18 @@ static void do_server_recv(int f_in, int f_out, int argc,char *argv[]) ...@@ -350,9 +350,18 @@ static void do_server_recv(int f_in, int f_out, int argc,char *argv[])
extern int delete_mode; extern int delete_mode;
extern int delete_excluded; extern int delete_excluded;
extern int am_daemon; extern int am_daemon;
extern int module_id;
extern int am_sender;
if (verbose > 2) if (verbose > 2)
rprintf(FINFO,"server_recv(%d) starting pid=%d\n",argc,(int)getpid()); rprintf(FINFO,"server_recv(%d) starting pid=%d\n",argc,(int)getpid());
if (am_daemon && lp_read_only(module_id) && !am_sender) {
rprintf(FERROR,"ERROR: module is read only\n");
exit_cleanup(RERR_SYNTAX);
return;
}
if (argc > 0) { if (argc > 0) {
dir = argv[0]; dir = argv[0];
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment