Commit a6c6f8e6 authored by Wayne Davison's avatar Wayne Davison

Use FLOG instead of FERROR for config errors.

parent ee6e80c7
...@@ -558,7 +558,7 @@ static int map_parameter(char *parmname) ...@@ -558,7 +558,7 @@ static int map_parameter(char *parmname)
if (strwicmp(parm_table[iIndex].label, parmname) == 0) if (strwicmp(parm_table[iIndex].label, parmname) == 0)
return(iIndex); return(iIndex);
rprintf(FERROR, "Unknown Parameter encountered: \"%s\"\n", parmname); rprintf(FLOG, "Unknown Parameter encountered: \"%s\"\n", parmname);
return(-1); return(-1);
} }
...@@ -584,7 +584,7 @@ static BOOL set_boolean(BOOL *pb, char *parmvalue) ...@@ -584,7 +584,7 @@ static BOOL set_boolean(BOOL *pb, char *parmvalue)
*pb = False; *pb = False;
else else
{ {
rprintf(FERROR, "Badly formed boolean in configuration file: \"%s\".\n", rprintf(FLOG, "Badly formed boolean in configuration file: \"%s\".\n",
parmvalue); parmvalue);
bRetval = False; bRetval = False;
} }
...@@ -671,7 +671,7 @@ static BOOL lp_do_parameter(int snum, char *parmname, char *parmvalue) ...@@ -671,7 +671,7 @@ static BOOL lp_do_parameter(int snum, char *parmname, char *parmvalue)
if (parmnum < 0) if (parmnum < 0)
{ {
rprintf(FERROR, "IGNORING unknown parameter \"%s\"\n", parmname); rprintf(FLOG, "IGNORING unknown parameter \"%s\"\n", parmname);
return(True); return(True);
} }
...@@ -682,7 +682,7 @@ static BOOL lp_do_parameter(int snum, char *parmname, char *parmvalue) ...@@ -682,7 +682,7 @@ static BOOL lp_do_parameter(int snum, char *parmname, char *parmvalue)
parm_ptr = def_ptr; parm_ptr = def_ptr;
} else { } else {
if (parm_table[parmnum].class == P_GLOBAL) { if (parm_table[parmnum].class == P_GLOBAL) {
rprintf(FERROR, "Global parameter %s found in service section!\n",parmname); rprintf(FLOG, "Global parameter %s found in service section!\n",parmname);
return(True); return(True);
} }
parm_ptr = ((char *)pSERVICE(snum)) + PTR_DIFF(def_ptr,&sDefault); parm_ptr = ((char *)pSERVICE(snum)) + PTR_DIFF(def_ptr,&sDefault);
...@@ -794,7 +794,7 @@ static BOOL do_section(char *sectionname) ...@@ -794,7 +794,7 @@ static BOOL do_section(char *sectionname)
if ((iServiceIndex=add_a_service(&sDefault,sectionname)) < 0) if ((iServiceIndex=add_a_service(&sDefault,sectionname)) < 0)
{ {
rprintf(FERROR,"Failed to add a new service\n"); rprintf(FLOG, "Failed to add a new service\n");
return(False); return(False);
} }
} }
......
...@@ -211,7 +211,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) ) ...@@ -211,7 +211,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) )
bufr = realloc_array( bufr, char, bSize ); bufr = realloc_array( bufr, char, bSize );
if( NULL == bufr ) if( NULL == bufr )
{ {
rprintf(FERROR, "%s Memory re-allocation failure.", func); rprintf(FLOG, "%s Memory re-allocation failure.", func);
return( False ); return( False );
} }
} }
...@@ -223,7 +223,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) ) ...@@ -223,7 +223,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) )
bufr[end] = '\0'; bufr[end] = '\0';
if( 0 == end ) /* Don't allow an empty name. */ if( 0 == end ) /* Don't allow an empty name. */
{ {
rprintf(FERROR, "%s Empty section name in configuration file.\n", func ); rprintf(FLOG, "%s Empty section name in configuration file.\n", func );
return( False ); return( False );
} }
if( !sfunc( bufr ) ) /* Got a valid name. Deal with it. */ if( !sfunc( bufr ) ) /* Got a valid name. Deal with it. */
...@@ -236,7 +236,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) ) ...@@ -236,7 +236,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) )
if( i < 0 ) if( i < 0 )
{ {
bufr[end] = '\0'; bufr[end] = '\0';
rprintf(FERROR, "%s Badly formed line in configuration file: %s\n", rprintf(FLOG, "%s Badly formed line in configuration file: %s\n",
func, bufr ); func, bufr );
return( False ); return( False );
} }
...@@ -261,7 +261,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) ) ...@@ -261,7 +261,7 @@ static BOOL Section( FILE *InFile, BOOL (*sfunc)(char *) )
} }
/* We arrive here if we've met the EOF before the closing bracket. */ /* We arrive here if we've met the EOF before the closing bracket. */
rprintf(FERROR, "%s Unexpected EOF in the configuration file: %s\n", func, bufr ); rprintf(FLOG, "%s Unexpected EOF in the configuration file: %s\n", func, bufr );
return( False ); return( False );
} /* Section */ } /* Section */
...@@ -305,7 +305,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c ) ...@@ -305,7 +305,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c )
bufr = realloc_array( bufr, char, bSize ); bufr = realloc_array( bufr, char, bSize );
if( NULL == bufr ) if( NULL == bufr )
{ {
rprintf(FERROR, "%s Memory re-allocation failure.", func) ; rprintf(FLOG, "%s Memory re-allocation failure.", func) ;
return( False ); return( False );
} }
} }
...@@ -315,7 +315,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c ) ...@@ -315,7 +315,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c )
case '=': /* Equal sign marks end of param name. */ case '=': /* Equal sign marks end of param name. */
if( 0 == end ) /* Don't allow an empty name. */ if( 0 == end ) /* Don't allow an empty name. */
{ {
rprintf(FERROR, "%s Invalid parameter name in config. file.\n", func ); rprintf(FLOG, "%s Invalid parameter name in config. file.\n", func );
return( False ); return( False );
} }
bufr[end++] = '\0'; /* Mark end of string & advance. */ bufr[end++] = '\0'; /* Mark end of string & advance. */
...@@ -329,7 +329,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c ) ...@@ -329,7 +329,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c )
if( i < 0 ) if( i < 0 )
{ {
bufr[end] = '\0'; bufr[end] = '\0';
rprintf(FERROR, "%s Ignoring badly formed line in configuration file: %s\n", rprintf(FLOG, "%s Ignoring badly formed line in configuration file: %s\n",
func, bufr ); func, bufr );
return( True ); return( True );
} }
...@@ -340,7 +340,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c ) ...@@ -340,7 +340,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c )
case '\0': /* Shouldn't have EOF within param name. */ case '\0': /* Shouldn't have EOF within param name. */
case EOF: case EOF:
bufr[i] = '\0'; bufr[i] = '\0';
rprintf(FERROR, "%s Unexpected end-of-file at: %s\n", func, bufr ); rprintf(FLOG, "%s Unexpected end-of-file at: %s\n", func, bufr );
return( True ); return( True );
default: default:
...@@ -370,7 +370,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c ) ...@@ -370,7 +370,7 @@ static BOOL Parameter( FILE *InFile, BOOL (*pfunc)(char *, char *), int c )
bufr = realloc_array( bufr, char, bSize ); bufr = realloc_array( bufr, char, bSize );
if( NULL == bufr ) if( NULL == bufr )
{ {
rprintf(FERROR, "%s Memory re-allocation failure.", func) ; rprintf(FLOG, "%s Memory re-allocation failure.", func) ;
return( False ); return( False );
} }
} }
...@@ -485,14 +485,14 @@ static FILE *OpenConfFile( char *FileName ) ...@@ -485,14 +485,14 @@ static FILE *OpenConfFile( char *FileName )
if( NULL == FileName || 0 == *FileName ) if( NULL == FileName || 0 == *FileName )
{ {
rprintf(FERROR,"%s No configuration filename specified.\n", func); rprintf(FLOG, "%s No configuration filename specified.\n", func);
return( NULL ); return( NULL );
} }
OpenedFile = fopen( FileName, "r" ); OpenedFile = fopen( FileName, "r" );
if( NULL == OpenedFile ) if( NULL == OpenedFile )
{ {
rsyserr(FERROR, errno, "unable to open configuration file \"%s\"", rsyserr(FLOG, errno, "unable to open configuration file \"%s\"",
FileName); FileName);
} }
...@@ -534,7 +534,7 @@ BOOL pm_process( char *FileName, ...@@ -534,7 +534,7 @@ BOOL pm_process( char *FileName,
bufr = new_array( char, bSize ); bufr = new_array( char, bSize );
if( NULL == bufr ) if( NULL == bufr )
{ {
rprintf(FERROR,"%s memory allocation failure.\n", func); rprintf(FLOG, "%s memory allocation failure.\n", func);
fclose(InFile); fclose(InFile);
return( False ); return( False );
} }
...@@ -548,7 +548,7 @@ BOOL pm_process( char *FileName, ...@@ -548,7 +548,7 @@ BOOL pm_process( char *FileName,
if( !result ) /* Generic failure. */ if( !result ) /* Generic failure. */
{ {
rprintf(FERROR,"%s Failed. Error returned from params.c:parse().\n", func); rprintf(FLOG, "%s Failed. Error returned from params.c:parse().\n", func);
return( False ); return( False );
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment