• Andreas Rheinhardt's avatar
    avcodec/cbs_sei: Fix leak of AVBufferRef on error · 70d22657
    Andreas Rheinhardt authored
    An AVBufferRef (and the corresponding AVBuffer and the underlying actual
    buffer) would leak in ff_cbs_sei_add_message() on error in case an error
    happened after its creation and before it has been attached to more
    permanent storage. Fix this by only creating the AVBufferRef immediately
    before attaching it to its intended target position.
    
    (Given that no SEI message currently created is refcounted, the above
    can't happen at the moment. But Coverity already nevertheless noticed:
    This commit fixes Coverity issue #1473521.)
    Reviewed-by: 's avatarMark Thompson <sw@jkqxz.net>
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
    70d22657
cbs_sei.c 10.4 KB