• Andreas Rheinhardt's avatar
    avcodec/mpegpicture: Split MPVPicture into WorkPicture and ordinary Pic · fe6037fd
    Andreas Rheinhardt authored
    There are two types of MPVPictures: Three (cur_pic, last_pic, next_pic)
    that are directly part of MpegEncContext and an array of MPVPictures
    that are separately allocated and are mostly accessed via pointers
    (cur|last|next)_pic_ptr; they are also used to store AVFrames in the
    encoder (necessary due to B-frames). As the name implies, each of the
    former is directly associated with one of the _ptr pointers:
    They actually share the same underlying buffers, but the ones
    that are part of the context can have their data pointers offset
    and their linesize doubled for field pictures.
    
    Up until now, each of these had their own references; in particular,
    there was an underlying av_frame_ref() to sync cur_pic and cur_pic_ptr
    etc. This is wasteful.
    
    This commit changes this relationship: cur_pic, last_pic and next_pic
    now become MPVWorkPictures; this structure does not have an AVFrame
    at all any more, but only the cached values of data and linesize.
    It also contains a pointer to the corresponding MPVPicture, establishing
    a more natural relationsship between the two.
    This already means that creating the context-pictures from the pointers
    can no longer fail.
    
    What has not been changed is the fact that the MPVPicture* pointers
    are not ownership pointers and that the MPVPictures are part of an
    array of MPVPictures that is owned by a single AVCodecContext.
    Doing so will be done in a latter commit.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@outlook.com>
    fe6037fd
d3d12va_vc1.c 7.36 KB