• Anton Khirnov's avatar
    fftools/ffmpeg: rework -shortest implementation · 4740fea7
    Anton Khirnov authored
    The -shortest option (which finishes the output file at the time the
    shortest stream ends) is currently implemented by faking the -t option
    when an output stream ends. This approach is fragile, since it depends
    on the frames/packets being processed in a specific order. E.g. there
    are currently some situations in which the output file length will
    depend unpredictably on unrelated factors like encoder delay. More
    importantly, the present work aiming at splitting various ffmpeg
    components into different threads will make this approach completely
    unworkable, since the frames/packets will arrive in effectively random
    order.
    
    This commit introduces a "sync queue", which is essentially a collection
    of FIFOs, one per stream. Frames/packets are submitted to these FIFOs
    and are then released for further processing (encoding or muxing) when
    it is ensured that the frame in question will not cause its stream to
    get ahead of the other streams (the logic is similar to libavformat's
    interleaving queue).
    
    These sync queues are then used for encoding and/or muxing when the
    -shortest option is specified.
    
    A new option – -shortest_buf_duration – controls the maximum number of
    queued packets, to avoid runaway memory usage.
    
    This commit changes the results of the following tests:
    - copy-shortest[12]: the last audio frame is now gone. This is
      correct, since it actually outlasts the last video frame.
    - shortest-sub: the video packets following the last subtitle packet are
      now gone. This is also correct.
    4740fea7
ffmpeg.mak 15 KB