• Timo Rothenpieler's avatar
    avutil/mem: limit alignment to maximum simd align · 7945d30e
    Timo Rothenpieler authored
    FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs,
    which then end up heap-allocated.
    By declaring any variable in a struct, or tree of structs, to be 32 byte
    aligned, it allows the compiler to safely assume the entire struct
    itself is also 32 byte aligned.
    
    This might make the compiler emit code which straight up crashes or
    misbehaves in other ways, and at least in one instances is now
    documented to actually do (see ticket 10549 on trac).
    The issue there is that an unrelated variable in SingleChannelElement is
    declared to have an alignment of 32 bytes. So if the compiler does a copy
    in decode_cpe() with avx instructions, but ffmpeg is built with
    --disable-avx, this results in a crash, since the memory is only 16 byte
    aligned.
    
    Mind you, even if the compiler does not emit avx instructions, the code
    is still invalid and could misbehave. It just happens not to. Declaring
    any variable in a struct with a 32 byte alignment promises 32 byte
    alignment of the whole struct to the compiler.
    
    This patch limits the maximum alignment to the maximum possible simd
    alignment according to configure.
    While not perfect, it at the very least gets rid of a lot of UB, by
    matching up the maximum DECLARE_ALIGNED value with the alignment of heap
    allocations done by lavu.
    7945d30e
mem.c 12.8 KB