Commit 01b9abd7 authored by Brendan Hack's avatar Brendan Hack Committed by Paul B Mahol

avfilter/vf_frei0r: set align to 1 for frei0r frames

The frei0r API requires linesize to be width * 4.
Since the align property of ff_default_get_video_buffer2
specifies line alignment, not buffer alignment, the
previous value of 16 breaks this requirement for frames
whose width is a multiple of 8, but not a multiple of 16
as it adds extra padding to ensure line aligment.

Fix Trac ticket #9873
parent 17987b37
...@@ -359,14 +359,17 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) ...@@ -359,14 +359,17 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
{ {
Frei0rContext *s = inlink->dst->priv; Frei0rContext *s = inlink->dst->priv;
AVFilterLink *outlink = inlink->dst->outputs[0]; AVFilterLink *outlink = inlink->dst->outputs[0];
AVFrame *out = ff_default_get_video_buffer2(outlink, outlink->w, outlink->h, 16); /* align parameter is the line alignment, not the buffer alignment.
* frei0r expects line size to be width*4 so we want an align of 1
* to ensure lines aren't padded out. */
AVFrame *out = ff_default_get_video_buffer2(outlink, outlink->w, outlink->h, 1);
if (!out) if (!out)
goto fail; goto fail;
av_frame_copy_props(out, in); av_frame_copy_props(out, in);
if (in->linesize[0] != out->linesize[0]) { if (in->linesize[0] != out->linesize[0]) {
AVFrame *in2 = ff_default_get_video_buffer2(outlink, outlink->w, outlink->h, 16); AVFrame *in2 = ff_default_get_video_buffer2(outlink, outlink->w, outlink->h, 1);
if (!in2) if (!in2)
goto fail; goto fail;
av_frame_copy(in2, in); av_frame_copy(in2, in);
...@@ -481,7 +484,7 @@ static int source_config_props(AVFilterLink *outlink) ...@@ -481,7 +484,7 @@ static int source_config_props(AVFilterLink *outlink)
static int source_request_frame(AVFilterLink *outlink) static int source_request_frame(AVFilterLink *outlink)
{ {
Frei0rContext *s = outlink->src->priv; Frei0rContext *s = outlink->src->priv;
AVFrame *frame = ff_default_get_video_buffer2(outlink, outlink->w, outlink->h, 16); AVFrame *frame = ff_default_get_video_buffer2(outlink, outlink->w, outlink->h, 1);
if (!frame) if (!frame)
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment