Commit 3a22bc03 authored by Michael Niedermayer's avatar Michael Niedermayer

avcodec/binkaudio: reset ch_offset on errors

Fixes: NULL pointer dereference
Fixes: 45955/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINKAUDIO_DCT_fuzzer-4842044192849920

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegReviewed-by: 's avatarPaul B Mahol <onemda@gmail.com>
Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
parent 7fbf1dd4
......@@ -329,6 +329,7 @@ again:
avctx->codec->id == AV_CODEC_ID_BINKAUDIO_DCT,
FFMIN(MAX_CHANNELS, s->channels - s->ch_offset), s->ch_offset)) {
av_log(avctx, AV_LOG_ERROR, "Incomplete packet\n");
s->ch_offset = 0;
return AVERROR_INVALIDDATA;
}
s->ch_offset += MAX_CHANNELS;
......@@ -347,6 +348,7 @@ again:
return 0;
fail:
s->ch_offset = 0;
av_packet_unref(s->pkt);
return ret;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment