1. 03 May, 2022 23 commits
  2. 02 May, 2022 12 commits
  3. 01 May, 2022 2 commits
    • Paul B Mahol's avatar
    • Felix LeClair's avatar
      avcodec/x86/hevc_mc: Fix AVX-512-VNNI_hevc_qpel_filters_avx512icl · 987d2c10
      Felix LeClair authored
      Issue: On extremely new hardware using either IceLake or super sets of
      Intel IceLakes avx512 instructions, commit
      d4cd8830 causes build issues.
      Specifically a NASM macro expansion of qpel_filter_v is never properly
      defined/initialized.
      
      The issue is the definition was erroneously placed inside a conditional
      which will not trigger unless the original definition failed (has to do
      with if PIC is defined, becomes a bit of a catch 22)
      Specifically the error is
      
      X86ASM    libavcodec/x86/hevc_mc.o
      libavcodec/x86/hevc_mc.asm:1854: error: symbol `..@88472.table' not defined
      libavcodec/x86/hevc_mc.asm:1806: ... from macro
      `HEVC_PUT_HEVC_QPEL_HV_AVX512ICL' defined here
      libavcodec/x86/hevc_mc.asm:1730: ... from macro `QPEL_FILTER_V' defined here
      ...
      repeats a few times...
      ...
      make: *** [ffbuild/common.mak:100: libavcodec/x86/hevc_mc.o] Error 1
      ```
      Specific error was discussed by kurosu and myself (fclc) on the
      ffmpeg-devel irc.
      
      This commit fixes the above by swapping lines 1796 and 1795, moving the
      define out of the conditional
      
      Side note: It seems fate didn't pick up on this, may merit looking into
      (as mentioned by nevcairiel).
      Reviewed-by: 's avatarWu Jianhua <toqsxw@outlook.com>
      Signed-off-by: 's avatarFelix LeClair (FCLC) <felix.leclair123@hotmail.com>
      Signed-off-by: 's avatarMarton Balint <cus@passwd.hu>
      987d2c10
  4. 30 Apr, 2022 3 commits