• Andreas Rheinhardt's avatar
    avutil/dict: Error out in case of key == NULL · 187cd278
    Andreas Rheinhardt authored
    Up until now, using NULL as key in av_dict_get() on a non-empty
    AVDictionary would crash; using NULL as key in av_dict_set()
    would also crash for a non-empty AVDictionary unless AV_DICT_MULTIKEY
    was set; in case the dictionary was initially empty or AV_DICT_MULTIKEY
    was set, it was even possible for av_dict_set() to succeed when
    adding a NULL key, namely when one uses a value != NULL and
    the AV_DICT_DONT_STRDUP_VAL flag. Using av_dict_get() on such
    an AVDictionary will usually lead to crashes, though.
    
    Fix this by actually checking for key in both functions; error out
    if they are NULL.
    
    While just at it, also stop relying on av_strdup(NULL) to return NULL
    in av_dict_set().
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@outlook.com>
    187cd278
Name
Last commit
Last update
..
.gitignore Loading commit data...
adler32.c Loading commit data...
aes.c Loading commit data...
aes_ctr.c Loading commit data...
audio_fifo.c Loading commit data...
avstring.c Loading commit data...
base64.c Loading commit data...
blowfish.c Loading commit data...
bprint.c Loading commit data...
camellia.c Loading commit data...
cast5.c Loading commit data...
channel_layout.c Loading commit data...
color_utils.c Loading commit data...
cpu.c Loading commit data...
cpu_init.c Loading commit data...
crc.c Loading commit data...
des.c Loading commit data...
dict.c Loading commit data...
display.c Loading commit data...
encryption_info.c Loading commit data...
error.c Loading commit data...
eval.c Loading commit data...
fifo.c Loading commit data...
file.c Loading commit data...
hash.c Loading commit data...
hmac.c Loading commit data...
hwdevice.c Loading commit data...
imgutils.c Loading commit data...
integer.c Loading commit data...
lfg.c Loading commit data...
lls.c Loading commit data...
log.c Loading commit data...
lzo.c Loading commit data...
md5.c Loading commit data...
murmur3.c Loading commit data...
opt.c Loading commit data...
parseutils.c Loading commit data...
pca.c Loading commit data...
pixdesc.c Loading commit data...
pixelutils.c Loading commit data...
pixfmt_best.c Loading commit data...
random_seed.c Loading commit data...
rational.c Loading commit data...
ripemd.c Loading commit data...
sha.c Loading commit data...
sha512.c Loading commit data...
softfloat.c Loading commit data...
tea.c Loading commit data...
tree.c Loading commit data...
twofish.c Loading commit data...
utf8.c Loading commit data...
uuid.c Loading commit data...
xtea.c Loading commit data...