Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
L
libvmod-ece
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
uplex-varnish
libvmod-ece
Commits
bfc395da
Commit
bfc395da
authored
Sep 13, 2019
by
Geoff Simmons
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bugfix finalizing the mutex for key memory pages.
parent
5cad086d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
6 deletions
+10
-6
keys.c
src/keys.c
+3
-1
00basic.vtc
src/tests/00basic.vtc
+7
-5
No files found.
src/keys.c
View file @
bfc395da
...
...
@@ -77,6 +77,7 @@ static struct key_ent key_tbl[UINT8_MAX + 1];
static
long
pagesz
=
0
;
static
struct
VSC_lck
*
lck_page
;
static
struct
vsc_seg
*
lck_page_vsc_seg
;
static
struct
lock
page_mtx
;
/* List of allocated key pages */
...
...
@@ -190,7 +191,7 @@ KEY_Init(VRT_CTX)
return
(
-
1
);
}
lck_page
=
Lck_CreateClass
(
NULL
,
"ece.key_mem"
);
lck_page
=
Lck_CreateClass
(
&
lck_page_vsc_seg
,
"ece.key_mem"
);
AN
(
lck_page
);
Lck_New
(
&
page_mtx
,
lck_page
);
if
(
key_alloc_page
(
ctx
)
!=
0
)
...
...
@@ -289,6 +290,7 @@ KEY_Fini(void)
}
}
Lck_Delete
(
&
page_mtx
);
Lck_DestroyClass
(
&
lck_page_vsc_seg
);
}
void
...
...
src/tests/00basic.vtc
View file @
bfc395da
...
...
@@ -24,11 +24,8 @@ varnish v1 -cli "vcl.use vcl2"
varnish v1 -cli "vcl.discard vcl1"
varnish v1 -cli "vcl.list"
# Lock destroyed on last discard
varnish v1 -vsc LCK.ece.key_mem.*
varnish v1 -expect LCK.ece.key_mem.creat == 1
varnish v1 -expect LCK.ece.key_mem.destroy == 1
varnish v1 -expect LCK.ece.key_mem.locks == 1
# Lock destroyed on last discard (log shows no LCK.ece.key_mem.*).
varnish v1 -vsc LCK.*
varnish v1 -vcl {
import ${vmod_ece};
...
...
@@ -58,3 +55,8 @@ client c1 {
expect resp.http.x-version ~ "^.+$"
expect resp.http.x-libcrypto-version ~ "^.+$"
} -run
# Lock exists again after new load.
varnish v1 -vsc LCK.ece.key_mem.*
varnish v1 -expect LCK.ece.key_mem.creat == 1
varnish v1 -expect LCK.ece.key_mem.locks == 1
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment