add tests for the posix_syntax option

src/tests/compile_fail.vtc

@@ -64,6 +64,171 @@ varnish v1 -errvcl {vmod re2 error: Cannot compile 'a\' in bad constructor: trai
 	backend b { .host = "${bad_ip}"; }
 
 	sub vcl_init {
-	        new bad = re2.regex("a\");
+	        new bad = re2.regex("a\"); #"
+	}
+}
+
+# Tests from re2 testing/parse_test.cc, first regexen that are valid in
+# Perl syntax but not in POSIX.
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("[a-b-c]");
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '[a-b-c]' in bad constructor: invalid character class range: -c} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("[a-b-c]", posix_syntax=true);
+	}
+}
+
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("\Qabc\E");
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '\Qabc\E' in bad constructor: invalid escape sequence: \Q} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("\Qabc\E", posix_syntax=true);
+	}
+}
+
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("(?:a)");
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '(?:a)' in bad constructor: no argument for repetition operator: ?} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("(?:a)", posix_syntax=true);
+	}
+}
+
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("(?P<name>a)");
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '(?P<name>a)' in bad constructor: no argument for repetition operator: ?} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("(?P<name>a)", posix_syntax=true);
+	}
+}
+
+# Now regex that are valid in POSIX syntax but not in Perl.
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("(a++)", posix_syntax=true);
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '(a++)' in bad constructor: bad repetition operator: ++} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("(a++)");
+	}
+}
+
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("(a**)", posix_syntax=true);
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '(a**)' in bad constructor: bad repetition operator: **} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("(a**)");
+	}
+}
+
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("(a?*)", posix_syntax=true);
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '(a?*)' in bad constructor: bad repetition operator: ?*} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("(a?*)");
+	}
+}
+
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("(a+*)", posix_syntax=true);
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '(a+*)' in bad constructor: bad repetition operator: +*} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("(a+*)");
+	}
+}
+
+varnish v1 -vcl {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new good = re2.regex("(a{1}*)", posix_syntax=true);
+	}
+}
+
+varnish v1 -errvcl {vmod re2 error: Cannot compile '(a{1}*)' in bad constructor: bad repetition operator: {1}*} {
+	import re2 from "${vmod_topbuild}/src/.libs/libvmod_re2.so";
+	backend b { .host = "${bad_ip}"; }
+
+	sub vcl_init {
+	        new bad = re2.regex("(a{1}*)");
 	}
 }