Flexelinting

src/flint.lnt

@@ -17,6 +17,9 @@
 -esym(765, tus_files_VSPLAY_*)
 -esym(768, Vmod_vmod_*_Func::*)
 -efile(766, *_if.c)
+-esym(528, vmod_priv_blob*, VGC_*)
+-esym(843, vmod_priv_blob*, VGC_*)
+-esym(844, vmod_priv_blob*, VGC_*)
 
 // not fully understood
 -efunc(413, *_VSPLAY_NEXT)

src/tbl_hash_enum.h

+/*lint -save -e525 -e539 */
 // HENUM(tusname, blobdigestenum)
 HENUM(crc32, CRC32)
 HENUM(icrc32, ICRC32)
@@ -13,3 +14,4 @@ HENUM(sha3_384, SHA3_384)
 HENUM(sha3_512, SHA3_512)
 HENUM(sha512, SHA512)
 #undef HENUM
+/*lint -restore */

src/tbl_method.h

+/*lint -save -e525 -e539 */
 MET(OPTIONS)
 MET(POST)
 MET(HEAD)
@@ -6,3 +7,4 @@ MET(DELETE)
 MET(GET)
 
 #undef MET
+/*lint -restore */

src/tus_blob.c

@@ -141,7 +141,7 @@ tus_chksum_fini(VRT_CTX) {
 #define HENUM(t, b) if (digest_ ## t != NULL)			\
 		vmod_blobdigest->f_digest__fini(&digest_ ## t);
 #include "tbl_hash_enum.h"
-	REPLACE(hashes, NULL);
+	REPLACE(hashes, NULL);//lint !e539
 	if (dl_vmod_blob != NULL)
 		(void) dlclose(dl_vmod_blob);
 	if (dl_vmod_blobdigest != NULL)

src/tus_file.c

@@ -418,7 +418,7 @@ tus_mmap_header(int fd)
 	    MAP_SHARED | MAP_NORESERVE, fd, 0));
 }
 
-static char * empty = "";
+static char * const empty = "";
 
 void
 tus_file_complete(struct tus_file_core *fcore)
@@ -1116,7 +1116,7 @@ struct tus_suck {
 };
 
 static int
-tus_suck_finish(struct tus_suck_common *sc,
+tus_suck_finish(const struct tus_suck_common *sc,
     ssize_t written, const void *ptr, ssize_t len)
 {
 	if (written > 0) {
@@ -1191,7 +1191,7 @@ static int v_matchproto_(objiterate_f)
 tus_suck_mmap_f(void *priv, unsigned flush, const void *ptr, ssize_t len)
 {
 	struct tus_suck_mmap *sm;
-	struct tus_suck_common *sc;
+	const struct tus_suck_common *sc;
 	void *wptr;
 
 	CAST_OBJ_NOTNULL(sm, priv, TUS_SUCK_MMAP_MAGIC);
@@ -1224,7 +1224,7 @@ static int
 tus_suck_mmap_truncate_f(void *priv, off_t length)
 {
 	struct tus_suck_mmap *sm;
-	struct tus_suck_common *sc;
+	const struct tus_suck_common *sc;
 	void *wptr;
 
 	CAST_OBJ_NOTNULL(sm, priv, TUS_SUCK_MMAP_MAGIC);
@@ -1236,6 +1236,7 @@ tus_suck_mmap_truncate_f(void *priv, off_t length)
 
 	wptr = (char *)sm->ptr + length;
 	memset(wptr, 0, *sc->upload_offset - length);
+	return (0);
 }
 
 static inline struct tus_suck_common *