fellow_storage: Clarify error handling for _getspace()

parent 2de8497c
......@@ -969,7 +969,14 @@ sfemem_getspace(struct worker *wrk, struct objcore *oc, ssize_t *ssz,
out:
#endif
if (fcr.status != fcr_ok) {
VSLb(wrk->vsl, SLT_Error, "GetSpace: %s",
/*
* XXX can not fail the oc here:
* Assert error in vbf_fetch_thread(), cache/cache_fetch.c line 1124:
* Condition((oc->flags & OC_F_FAILED) == 0) not true.
*/
//XXX oc_fcr_handle(wrk, oc, fcr);
VSLb(wrk->vsl, SLT_Error, "fellow %s: %s",
fellow_cache_res_s[fcr.status],
fcr.r.err ? fcr.r.err : "Unknown error");
*ssz = -1;
return (0);
......
......@@ -43,6 +43,13 @@ varnish v1 -vcl+backend {
}
}
logexpect l1 -v v1 -g vxid -q {BereqURL ~ "^/256k.1"} {
fail add * End
expect * * Error "objsize_max reached"
expect 0 = FetchError "Could not get storage"
fail clear
} -start
client c1 {
txreq -url "/256k"
rxresp
......@@ -70,6 +77,7 @@ client c2 {
client c1 -wait
client c2 -wait
server s1 -wait
logexpect l1 -wait
server s1 {
rxreq
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment