• Nils Goroll's avatar
    Decide against extending the log at this point - no oa_present yet · 7125d0c7
    Nils Goroll authored
    With the previous commit, we restore the objcore's oa_present field
    when we first read the object.
    
    On top of that, it would be nice if we could restore the field or at
    least the bit for OA_VARY when we read the log, because a cache lookup
    checks it and could avoid reading objects if the OA_VARY bit is not
    set.
    
    On the other hand, if vary is used, the object needs to be read
    anyway, so restoring oa_present during log read only payed off for no
    vary.
    
    The straight forward solution would be to add 2 bytes to struct
    fellow_dle_obj. This would
    
    - require a DLE version bump and compatibility code
    - bump the dle size from 72 to 80 bytes (because alignment)
    - consequently, reduce FELLOW_DISK_LOG_BLOCK_ENTRIES from 56 to 4032 /
      80 = 50
    
    All this is possible and part of the fellow design, but at
    this point I conclude that it is not worth the effort.
    
    Another option would be to cram two bits into the existing
    fellow_dle_obj, for example by exploiting the fact that the sign bit
    of ban and t_origin is always zero. This could break backwards
    compatibility, so we prepare for the option, but do not implement it.
    
    All in all, we just add a TODO to add this when we need to extend the
    DLE anyway.
    
    Closes #17
    7125d0c7
Name
Last commit
Last update
..
foreign Loading commit data...
tbl Loading commit data...
vtc Loading commit data...
Makefile.am Loading commit data...
VSC_buddy.vsc Loading commit data...
VSC_fellow.vsc Loading commit data...
bitf.h Loading commit data...
bitsof.h Loading commit data...
buddy.c Loading commit data...
buddy.h Loading commit data...
buddy_storage.c Loading commit data...
buddy_storage.h Loading commit data...
buddy_tune.c Loading commit data...
buddy_tune.h Loading commit data...
buddy_util.h Loading commit data...
buddy_witness.h Loading commit data...
compiler.h Loading commit data...
debug.h Loading commit data...
fcs_states.doth Loading commit data...
fellow_cache.c Loading commit data...
fellow_cache.h Loading commit data...
fellow_cache_storage.h Loading commit data...
fellow_debug.h Loading commit data...
fellow_diag.h Loading commit data...
fellow_errhandling.h Loading commit data...
fellow_hash.c Loading commit data...
fellow_hash.h Loading commit data...
fellow_hashes.h Loading commit data...
fellow_inject.h Loading commit data...
fellow_io.h Loading commit data...
fellow_io_aio.c Loading commit data...
fellow_io_backend.h Loading commit data...
fellow_io_ioctl.c Loading commit data...
fellow_io_ioctl.h Loading commit data...
fellow_io_threads.c Loading commit data...
fellow_io_uring.c Loading commit data...
fellow_log.c Loading commit data...
fellow_log.h Loading commit data...
fellow_log_dbg.c Loading commit data...
fellow_log_dle_chg.h Loading commit data...
fellow_log_iter_out.h Loading commit data...
fellow_log_storage.h Loading commit data...
fellow_log_test.c Loading commit data...
fellow_pri.h Loading commit data...
fellow_regionlist.h Loading commit data...
fellow_sha256.c Loading commit data...
fellow_sha256.h Loading commit data...
fellow_stash.h Loading commit data...
fellow_storage.c Loading commit data...
fellow_storage.h Loading commit data...
fellow_storage_deref.h Loading commit data...
fellow_task.h Loading commit data...
fellow_testenv.c Loading commit data...
fellow_testenv.h Loading commit data...
fellow_tune.c Loading commit data...
fellow_tune.h Loading commit data...
flint.h Loading commit data...
flint.lnt Loading commit data...
pow2_units.c Loading commit data...
pow2_units.h Loading commit data...
slash-counters.rst Loading commit data...
slashmap.c Loading commit data...
slashmap.h Loading commit data...
slashmap.rst.in Loading commit data...
slashmap_options.h Loading commit data...
vmod_slash.c Loading commit data...
vmod_slash.man.rst Loading commit data...
vmod_slash.vcc Loading commit data...
vmod_slash_loadmasters.c Loading commit data...