Cleare do_stream on all esi objects, including included objects.

Found & Fixed by: Martin Fixes #978

Cleare do_stream on all esi objects, including included objects.
Found & Fixed by: Martin Fixes #978
0f8805f5 · Poul-Henning Kamp · Tollef Fog Heen · 6f7c8a77 · 0f8805f5 · 0f8805f5
Commit 0f8805f5 authored Aug 17, 2011 by Poul-Henning Kamp Committed by Tollef Fog Heen Aug 17, 2011
Hide whitespace changes
Inline Side-by-side

Showing with 41 additions and 1 deletion

cache_center.c bin/varnishd/cache_center.c +1 -1

r00978.vtc bin/varnishtest/tests/r00978.vtc +40 -0

No files found.
--- a/bin/varnishd/cache_center.c
+++ b/bin/varnishd/cache_center.c
@@ -718,7 +718,7 @@ cnt_fetchbody(struct sess *sp)
 	else if (sp->wrk->is_gzip)
 		sp->wrk->vfp = &vfp_testgzip;

-	if (sp->wrk->do_esi)
+	if (sp->wrk->do_esi || sp->esi_level > 0)
 		sp->wrk->do_stream = 0;
 	if (!sp->wantbody)
 		sp->wrk->do_stream = 0;

--- a/bin/varnishtest/tests/r00978.vtc
+++ b/bin/varnishtest/tests/r00978.vtc
+varnishtest "r00978.vtc Test esi_level > 0 and do_stream"
+
+server s1 {
+	rxreq
+	expect req.url == "/"
+	txresp -body {
+		<html>
+		Before include
+		<esi:include src="/body" sr="foo"/>
+		After include
+	}
+	rxreq
+	expect req.url == "/body1"
+	txresp -body {
+		Included file
+	}
+} -start
+
+varnish v1 -vcl+backend {
+	sub vcl_recv {
+		if (req.esi_level > 0) {
+			set req.url = req.url + req.esi_level;
+		}
+	}
+	sub vcl_fetch {
+		if (req.url == "/") {
+			set beresp.do_esi = true;
+		}
+		set beresp.do_stream = true;
+	}
+} -start
+
+client c1 {
+	txreq
+	rxresp
+	expect resp.bodylen == 65
+	expect resp.status == 200
+} -run
+
+varnish v1 -expect esi_errors == 0