Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
U
unique-xids
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
uplex-varnish
unique-xids
Commits
3d406aa8
Commit
3d406aa8
authored
Dec 13, 2012
by
Martin Blix Grydeland
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't report ban_magic to the stevedores on insertion, but delay it
until ban compile. Document the reason.
parent
535fbe74
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
2 deletions
+10
-2
cache_ban.c
bin/varnishd/cache/cache_ban.c
+10
-2
No files found.
bin/varnishd/cache/cache_ban.c
View file @
3d406aa8
...
...
@@ -476,7 +476,15 @@ BAN_Insert(struct ban *b)
else
be
=
NULL
;
STV_BanInfo
(
BI_NEW
,
b
->
spec
,
ln
);
/* Notify stevedores */
/* ban_magic is magic, and needs to be inserted early to give
* a handle to grab a ref on. We don't report it here as the
* stevedores will not be opened and ready to accept it
* yet. Instead it is reported on BAN_Compile, which is after
* the stevedores has been opened, but before any new objects
* can have entered the cache (thus no objects in the mean
* time depending on ban_magic in the list) */
if
(
b
!=
ban_magic
)
STV_BanInfo
(
BI_NEW
,
b
->
spec
,
ln
);
/* Notify stevedores */
Lck_Unlock
(
&
ban_mtx
);
if
(
be
==
NULL
)
...
...
@@ -681,7 +689,7 @@ BAN_Compile(void)
ASSERT_CLI
();
AZ
(
ban_shutdown
);
/*
Notify stevedores
*/
/*
Do late reporting of ban_magic
*/
STV_BanInfo
(
BI_NEW
,
ban_magic
->
spec
,
ban_len
(
ban_magic
->
spec
));
ban_start
=
VTAILQ_FIRST
(
&
ban_head
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment