Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
U
unique-xids
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
uplex-varnish
unique-xids
Commits
7db894f9
Commit
7db894f9
authored
Nov 12, 2012
by
Poul-Henning Kamp
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Return false if req.backend.health is accessed in vcl_deliver{} where
this information is no longer available. Fixes #1228
parent
042a2d63
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
0 deletions
+24
-0
cache_vrt_var.c
bin/varnishd/cache/cache_vrt_var.c
+6
-0
r01228.vcl
bin/varnishtest/tests/r01228.vcl
+18
-0
No files found.
bin/varnishd/cache/cache_vrt_var.c
View file @
7db894f9
...
@@ -555,6 +555,12 @@ unsigned
...
@@ -555,6 +555,12 @@ unsigned
VRT_r_req_backend_healthy
(
const
struct
req
*
req
)
VRT_r_req_backend_healthy
(
const
struct
req
*
req
)
{
{
CHECK_OBJ_NOTNULL
(
req
,
REQ_MAGIC
);
CHECK_OBJ_NOTNULL
(
req
,
REQ_MAGIC
);
/*
* XXX: Not optimal, but we do not have a backend in vcl_deliver
* XXX: and we have to return something.
*/
if
(
req
->
director
==
NULL
)
return
(
0
);
CHECK_OBJ_NOTNULL
(
req
->
director
,
DIRECTOR_MAGIC
);
CHECK_OBJ_NOTNULL
(
req
->
director
,
DIRECTOR_MAGIC
);
return
(
VDI_Healthy
(
req
->
director
,
req
));
return
(
VDI_Healthy
(
req
->
director
,
req
));
}
}
bin/varnishtest/tests/r01228.vcl
0 → 100644
View file @
7db894f9
varnishtest "req.backend.healthy in vcl_deliver"
server s1 {
rxreq
txresp
} -start
varnish v1 -vcl+backend {
sub vcl_deliver {
set resp.http.x-foo = req.backend.healthy;
}
} -start
client c1 {
txreq
rxresp
expect resp.status == 200
} -run
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment