More flexelint cleanup

git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@4905 d4fa192b-c00b-0410-8231-f00ffab90ce4

bin/flint.lnt

@@ -3,20 +3,23 @@
 -ffc			// No automatic custody
 
 ///////////////////////////////////////////////////////////////////////
-// ../../config.h magic
+// Weirdness relating to varnish includes etc.
+
 -header(../../config.h)
 +libh ../../config.h
 -efile(451, ../../config.h)	// No include guard
 
+-esym(528, svnid)		// Sym not ref
 
-///////////////////////////////////////////////////////////////////////
-// varargs stuff
-
--emacro((???), va_arg)	// 415, 416, 416, 661, 662, 796, 797 ...
+-efile(451, shmlog_tags.h)	// No include guard
 
 ///////////////////////////////////////////////////////////////////////
 // assert() support, common to libvarnish and libvarnishapi
 -sem(vas_fail, r_no)
+-emacro(506, assert)    // constant value boolean
+-emacro(827, assert)    // loop not reachable
+-emacro(774, assert)    // booelan always true
+-emacro(527, WRONG)     // unreachable code
 
 ///////////////////////////////////////////////////////////////////////
 // <vqueue.h>
@@ -37,7 +40,16 @@
 ///////////////////////////////////////////////////////////////////////
 // miniobj
 
--emacro(755, CAST_OBJ)
+// -emacro(755, CAST_OBJ)		// glob macro not ref
+-emacro(779, REPLACE)		// string constant !=
+-emacro(774, REPLACE)		// if(bool) always true
+-emacro(506, REPLACE)		// const bool
+
+///////////////////////////////////////////////////////////////////////
+// VMB
+-emacro(755, VMB)		// glob macro not ref
+-emacro(755, VRMB)		// glob macro not ref
+-emacro(755, VWMB)		// glob macro not ref
 
 ///////////////////////////////////////////////////////////////////////
 // VSB
@@ -56,9 +68,16 @@
 -esym(534, vsb_putc)
 
 ///////////////////////////////////////////////////////////////////////
-// Ignore return values OK for these functions
+// System library/POSIX related
+///////////////////////////////////////////////////////////////////////
+
+// vararg simulation is imperfect (XXX: why ??)
+-emacro((???), va_arg)	// 415, 416, 416, 661, 662, 796, 797 ...
 
--esym(534, printf)
+// Fix strchr() semtics, it can only return NULL if arg2 != 0
+-sem(strchr, 1p, type(1), 2n == 0 ? (@p < 1p) : (@p < 1p || @p == 0 ))
+
+-esym(534, printf)	// Ignore retval
 -esym(534, fprintf)
 -esym(534, sprintf)
 
@@ -69,3 +88,11 @@
 -esym(534, strcat)
 -esym(534, strcpy)
 -esym(534, strlcpy)
+
+-sem(pthread_create, custodial(4))
+-emacro(413, offsetof)  // likely null pointer
+-emacro(736, isnan)  // loss of prec.
+
++libh(/usr/include/curses.h)
+-elib(659)		// no tokens after struct def.
+-elib(123)		// macro def. with arg at, (just warn)

bin/varnishd/flint.lnt

 -d__flexelint_v9__=1
 
--libdir(../../include)
--libdir(../../lib/)
-
-// -efile(765, ../../lib/)
-// -efile(765, ../../include/)
-// -efile(759, ../../lib/)
-// -efile(759, ../../include/)
-
 -esym(755, vct_*)
 -esym(759, vev_*)
 -esym(765, vev_*)
@@ -96,29 +88,16 @@
 -esym(458, VSL_stats)
 -esym(458, heritage)
 -esym(458, name_key)
--esym(528, svnid)
 
 //////////////
 
 +libh mgt_event.h
 
--elib(123)  // size is both a variable and a macro with args
--emacro(736, isnan)  // isnanf
--efile(766, ../../config.h)
--emacro(413, offsetof)	// likely null pointer
--emacro(527, WRONG)	// unreachable code
 -emacro(527, NEEDLESS_RETURN)	// unreachable code
 
 -emacro(702, WEXITSTATUS)	// signed shift right 
 -efunc(525, VCC_Return_Name)	// Negative indent
 
-
-
-
-// Fix strchr() semtics, it can only return NULL if arg2 != 0
--sem(strchr, 1p, type(1), 2n == 0 ? (@p < 1p) : (@p < 1p || @p == 0 ))
-
--sem(pthread_create, custodial(4))
 -sem(WS_Init, custodial(2))
 -sem(http_Setup, custodial(2))
 
@@ -140,9 +119,6 @@
 -emacro(506, isnan, isfinite)	// constant value boolean
 -emacro(736, isfinite)	// loss of precision
 -emacro(747, isnan)	// significant coersion
--emacro(506, assert)	// constant value boolean
--emacro(827, assert)	// loop not reachable
--emacro(774, assert)	// booelan always true
 -emacro(774, HTTPH)	// always false
 -emacro(527, ARGV_ERR)	// unreachable
 

bin/varnishncsa/flint.lnt

 
 +d__attribute__()=
 
-// Fix strchr() semtics, it can only return NULL if arg2 != 0
--sem(strchr, 1p, type(1), 2n == 0 ? (@p < 1p) : (@p < 1p || @p == 0 ))
-
 -e763	// Redundant declaration for symbol '...' previously declared
 -e726	// Extraneous comma ignored
 -e728	// Symbol ... not explicitly initialized
@@ -11,9 +8,6 @@
 -e785	// Too few initializers for aggregate 
 -e786	// String concatenation within initializer
 
-// cache.h
--emacro(506, INCOMPL) // Constant value Boolean
-
 // cache_center.c
 -efunc(525, CNT_Session)	// Negative indentation from line
 -efunc(525, http_FilterHeader)	// Negative indentation from line

bin/varnishtest/flint.lnt

 
-+libh mgt_event.h
-
--elib(123)  // size is both a variable and a macro with args
--emacro(736, isnan)  // isnanf
--efile(766, ../../config.h)
-
 -esym(850, av)
 
--esym(528, svnid)
-
 -e712	// 14      Info    712     Loss of precision (___) (___ to ___)
 -e747	// 16      Info    747     Significant prototype coercion (___) ___ to ___
 
 
-
-// Fix strchr() semtics, it can only return NULL if arg2 != 0
--sem(strchr, 1p, type(1), 2n == 0 ? (@p < 1p) : (@p < 1p || @p == 0 ))
-// 
-// -sem(vsb_new, @p == malloc(1))
-// -sem(vsb_delete, custodial(1))
--sem(lbv_assert, r_no)
--sem(lbv_xxxassert, r_no)
-// -sem(WS_Init, custodial(2))
-// -sem(http_Setup, custodial(2))
-// 
-// -ffc	// No automatic custody
-// 
 -e763	// Redundant declaration for symbol '...' previously declared
-// -e726	// Extraneous comma ignored
-// -e728	// Symbol ... not explicitly initialized
 -e716	// while(1) ... 
-// -e785	// Too few initializers for aggregate 
-// -e786	// String concatenation within initializer
-// 
--emacro(779, REPLACE)		// string constant !=
--emacro(774, REPLACE)		// if(bool) always true
--emacro(506, REPLACE)		// const bool
-// 
-// -emacro(506, isnan)	// constant value boolean
-// -emacro(747, isnan)	// significant coersion
-// -emacro(506, assert)	// constant value boolean
-// -emacro(827, assert)	// loop not reachable
-// -emacro(774, assert)	// booelan always true
-// -emacro(774, HTTPH)	// always false
-// 
-// // cache.h
-// -emacro(506, INCOMPL) // Constant value Boolean
-// 
-// // cache_center.c
-// -efunc(525, CNT_Session)	// Negative indentation from line
-// -efunc(525, http_FilterFields)	// Negative indentation from line
-// -efunc(539, http_FilterFields)	// Positive indentation from line
-// 
-// // cache_vcl.c
-// -efunc(525, vcl_handlingname)	// Negative indentation from line
-// -esym(528, vcl_handlingname)	// Not referenced
-// -e641	// Converting enum 'cli_status_e' to int
-// 
-// // Review all below this line ///////////////////////////////////////////////
 
 -e457 // unprotected write access 
 -e459 // unprotected access 
@@ -67,17 +16,3 @@
 -e737	// [45]  Loss of sign in promotion from int to unsigned
 -e713	// Loss of precision (assignment) (unsigned long long to long long)
 -e574	// Signed-unsigned mix with relational
-// -e712	// Loss of precision (assignment) (long long to
-// -e747	// Significant prototype coercion (arg. no. 2) long
-// 
-// /*
-// 
-// -e767	// Macro redef (system queue.h vs ours )
-// 
-// -e506	// Constant value boolean
-// -e818	// Pointer parameter '...' could be declared as pointing to const
-// -e774	// Boolean within 'if' always evaluates to False
-// -e534	// Ignoring return value of function
-// -e557	// unrecog format
-// 
-// */