Don't core dump on negative or execessively large fds in "order mode"

XXX: the 64k fd limitation should probably be fixed.

Don't core dump on negative or execessively large fds in "order mode"
XXX: the 64k fd limitation should probably be fixed.
38dd2742 · Poul-Henning Kamp · Tollef Fog Heen · ca5859d1 · 38dd2742
Commit 38dd2742 authored Aug 08, 2011 by Poul-Henning Kamp Committed by Tollef Fog Heen Aug 16, 2011
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

varnishlog.c bin/varnishlog/varnishlog.c +4 -0

No files found.
--- a/bin/varnishlog/varnishlog.c
+++ b/bin/varnishlog/varnishlog.c
@@ -97,6 +97,10 @@ h_order(void *priv, enum VSL_tag_e tag, unsigned fd, unsigned len,

 	struct VSM_data *vd = priv;

+	/* XXX: Just ignore any fd not inside the bitmap */
+	if (fd >= sizeof bitmap / sizeof bitmap[0])
+		return (0);
+
 	bitmap[fd] |= bm;

 	type = (spec & VSL_S_CLIENT) ? 'c' :