If we can't do it properly because of support for older
platforms, we can document it.

Ref: #20

Fixes: #17

Closes: #806120

As found in
https://anonscm.debian.org/cgit/pkg-varnish/pkg-varnish.git/.
Fixes #27.

NB: The vcache user is not used yet.

This allow simple downgrade of Varnish package, because Varnish API might
not be forward compatible (new libvarnishapi1 with old Varnish).

Fix by hardcoding as suggested by Federico Schwindt.

This change also reverts the pid file name change that was an uninteded
side effect of a59b3bdd in Nov 2015. That commit renamed the pid file
from varnishd.pid to varnish.pid.

From a maintenance branch perspective it is not a good thing to change
these names, but I think going back to the original is the least painful way
moving forward. We'll have systems with sysv init for many years still.

Fixes: #22

In case I get hit by a bus some time.

It is present in 8.25 (stretch), but that isn't much help
on el7.

Fixes Varnish Cache issue 1903 on https://github.com/varnishcache/varnish-cache/issues/1903

Fix name column since cold/warm pushed it on the right

Reported by: 	TanguyPatte

The usage of ExecStartPre was (as far as I remember) adopted because we
in sysv init scripts do a configtest before restart, and this looked
like the natural way to get the same functionality.

Systemd doesn't do this, if you ask for a restart it doesn't do any
checks before stopping the daemon.

As such this is just extra time spent starting up, as well as being very
noisy because we dump a lot of C code into the journal.

This was originally researched and removed by Federico Schwindt in
redhat/varnish.service inside Varnish-Cache.git, but the intent and
change was lost in the subsequent merging of packaging repositories.

Using the debian script from now on, with the exception of the reload snippets
which I don't have the opportunity to test properly at the moment.

This also takes care of a very confusing behaviour if you run
logrotate manually with just /etc/logrotate.d/varnish as argument.
No "rotate" line (otherwise inherited from logrotate.conf) means it
simply erases all of your log files in one go.

When running as an unprivileged user, writing the pid file
to /run/ isn't allowed.

As suggested by ssm and fgs.

In fbc85bb3 the use of type=forking was removed. This made #1794
reappear, as these tools when not daemonized exists when receiving
a SIGHUP.

This is clearly suboptimal for log rotation.

Roll back this in the packages for now.

On second thought, all release builds will be 4.0.3-x with x of 1 or
higher. A single dash should suffice.

This was the least confusing way I found to make sure it
is always is less than the release/final version.

Having diverging service files for Debian and Redhat without reason is
stupid.

Make them identical.

Make our life easier by having systemd tend to finding the
right process to restart.

varnishncsa.service should now be identical on Redhat and Debian
systems.

Fixes startup issue reported Steinar Gunderson.

In this case "beta1".