There is only python2 and python3 packages

to avoid unnecessary errors when running outside jenkins

Starting with el8 annobin is used to annotate ELF binaries and this is
set up via the %configure RPM macro. As a result annobin becomes a
requirement of the default cc_command in varnishd but it relies on GCC
spec files that are provided by redhat-rpm-config.

So, similar to how we explicitly require GCC at run time we now also
need to bring the annobin setup.

There was already a hint in b2ea64fd
that we lack some packaging stability from the platforms we support
and this is another occurrence. The configure script of a supported
Varnish release will find the tools we need.

This enables build support for el8 in addition to el7.

We don't care when a pipeline does not read the complete varnishadm
output because it found what it needed way before. However, we don't
want noise in the standard error with spurious broken pipe messages.

Closes #134

Slightly better diff with the --ignore-all-space option.

Refs #134

Refs #104

I was finally able to use sbuild on Fedora for all Varnish 6 Debian and
derivatives. I was able to confirm that the configure script doesn't
need help to find our documentation tools. Or rather, I was no longer
running in that error when I rushed the Python 3 transition.

https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-5f2841e1a2

And incidentally rst2html became mandatory in trunk. Because of another
python3 packaging "bug" on epel7 we don't have a stable virtual provides
for docutils, but we can get it via the stable:

    BuildRequires: python3-sphinx

The problem with dependency "stability" was our reliance on python3.4
packages, recently replaced by python3.6 packages when 3.4 reached its
EOL. With this change we should no longer have a problem when python
3.6 goes EOL too.

I needed to pass `--enablerepo testing` to check a python3-docutil
packaging fix.

Python 2 support is over in 3 quarters, and python 2 support is over in
2 days in Varnish.

In current trunk or soon-to-be Varnish 6.2 the format of vcl.list
changed and broke the varnishreload script. Because the temperature
and state column was split into two columns, field offsets became
off by one.

The forward slash character previously used inside the single column
is now part of the field separator when the output of vcl.list is
handled by awk, working for both Varnish 6.2 and previously supported
versions.

Refs #121

This broke the discard and label logic, since its column handling was also
off by one.

Refs #121

This reverts commit 0b999c1b.

More like major dirt on my glasses.

Instead of hand-rolling our own systemd integration, we can rely on RPM
macros maintained for us. This results in the following changes in the
main package's scriptlets:

    --- scripts.old	2019-02-14 10:50:21.039974337 +0100
    +++ scripts.new	2019-02-14 10:49:24.649144061 +0100
    @@ -12,14 +12,24 @@

     exit 0
     postinstall scriptlet (using /bin/sh):
    -/bin/systemctl daemon-reload >/dev/null 2>&1 || :
    -chown varnishlog:varnish /var/log/varnish/
     /sbin/ldconfig
    +
    +if [ $1 -eq 1 ] ; then
    +        # Initial installation
    +        systemctl preset varnish varnishncsa >/dev/null 2>&1 || :
    +fi
     preuninstall scriptlet (using /bin/sh):
    -if [ $1 -lt 1 ]; then
    -  # Package removal, not upgrade
    -  /bin/systemctl --no-reload disable varnish.service > /dev/null 2>&1 || :
    -  /bin/systemctl stop varnish.service > /dev/null 2>&1 || :
    -  /bin/systemctl stop varnishncsa.service > /dev/null 2>&1 || :
    +
    +if [ $1 -eq 0 ] ; then
    +        # Package removal, not upgrade
    +        systemctl --no-reload disable varnish varnishncsa > /dev/null 2>&1 || :
    +        systemctl stop varnish varnishncsa > /dev/null 2>&1 || :
     fi
    -postuninstall program: /sbin/ldconfig
    +postuninstall scriptlet (using /bin/sh):
    +/sbin/ldconfig
    +
    +systemctl daemon-reload >/dev/null 2>&1 || :
    +if [ $1 -ge 1 ] ; then
    +        # Package upgrade, not uninstall
    +        systemctl try-restart varnish varnishncsa >/dev/null 2>&1 || :
    +fi

The only major change is that the varnish and varnishncsa services will
be restarted during a varnish upgrade. This is needed because otherwise
reloading a VCL that uses vmod_std after the upgrade (and without
restarting) would fail because the running varnishd wouldn't recognize
the shared object's expected ABI.

One unrelated change is the handling of /var/log/varnish/ ownership. As
it was done until now a fresh install would yield a corrupted package:

    $ rpm --verify varnish
    .....UG..    /var/log/varnish

Since we already create the users and group before installing the files,
we can already ask RPM to chown the directory itself.

We build againt a bootstrapped "dist" archive so we can save a few
cycles here and there by not installing a redundant build system that
is not in use inside the schroot.

When we are building the binary packages inside an schroot, they will be
fetched and installed. We don't need them on the host running sbuild.

Fixes #101

unknown-section varnish-6.0/web
  Section: @SECTION@/web -> Section: web
  Section: @SECTION/libdevel -> libdevel
  The substitution line in the package-deb script got removed:
  sed -i -e "s|@SECTION@|varnish-$MAJOR|" "$DIST_DIR/debian/control

copyright-without-copyright-notice:
  The copyright file expected a certain 3 line header:
      Copyright YYYY Firstname Lastname <address@example.com>
      Copr. YYYY-YYYY Firstname Lastname <address@example.com>
      © YYYY,YYYY Firstname Lastname <address@example.com>

Added debian/source/format file with content "1.0"

READMEs:
 - Installing again the once-installed README.rst and README.packaging

VCLs:
- A non-commented version of builtin.vcl is not installed into
/usr/share/doc/varnish/examples anymore.

Fixes #104

While ultimately the goal is to automate virtual provides and requires
to the extent of out-of-tree modules, considering that for now package
maintainers would have to manually adjust their requirements, they
couldn't easily manage either 32bit or 64bit dependencies in a single
Requires tag. While we don't ship 32bit packages, distributions like
Fedora do.

Now a user can easily target the right architecture on a multilib system
with a single dependency:

    Requires: varnishd(abi)%{?_isa} = sha1

This is already part of the upgrade notes I'm redacting and I will amend
the wiki accordingly.

In other words on 64bit systems:

    Provides: varnishd(abi)(64bit) = sha1
    Provides: varnishd(vrt)(64bit) = x.y

Same as VMOD virtual provides.