the current vtc -rcvbuf implementation does not work on SunOS

Ref #2980

the current vtc -rcvbuf implementation does not work on SunOS
Ref #2980
09785c4e · Nils Goroll · bfbd2963 · 09785c4e · 09785c4e
Commit 09785c4e authored Apr 24, 2019 by Nils Goroll
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

s00010.vtc bin/varnishtest/tests/s00010.vtc +3 -0

vtc_http.c bin/varnishtest/vtc_http.c +2 -0

No files found.
--- a/bin/varnishtest/tests/s00010.vtc
+++ b/bin/varnishtest/tests/s00010.vtc
 varnishtest "client h1 send timeouts"

+# XXX See https://github.com/varnishcache/varnish-cache/pull/2980#issuecomment-486214661
+feature cmd {test $(uname) != "SunOS"}
+
 server s1 {
 	rxreq
 	txresp -bodylen 100000

--- a/bin/varnishtest/vtc_http.c
+++ b/bin/varnishtest/vtc_http.c
@@ -1918,6 +1918,8 @@ http_process(struct vtclog *vl, const char *spec, int sock, int *sfd,
 	hp->timeout = vtc_maxdur * 1000 / 2;

 	if (rcvbuf) {
+		// XXX setsockopt() too late on SunOS
+		// https://github.com/varnishcache/varnish-cache/pull/2980#issuecomment-486214661
 		hp->rcvbuf = rcvbuf;

 		oldbuf = 0;