Fix WS_Reserve() error handling

See #2967 for discussion

Fix WS_Reserve() error handling
See #2967 for discussion
0e32f166 · Nils Goroll · 458306fa · 0e32f166
Commit 0e32f166 authored Apr 07, 2019 by Nils Goroll
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

cache_http2_deliver.c bin/varnishd/http2/cache_http2_deliver.c +3 -1

No files found.
--- a/bin/varnishd/http2/cache_http2_deliver.c
+++ b/bin/varnishd/http2/cache_http2_deliver.c
@@ -226,8 +226,10 @@ h2_build_headers(struct vsb *resp, struct req *req)
 	ssize_t sz, sz1;

 	l = WS_Reserve(req->ws, 0);
-	if (l < 10)
+	if (l < 10) {
+		WS_Release(req->ws, 0);
 		return (-1);
+	}

 	AN(VSB_new(resp, req->ws->f, l, VSB_FIXEDLEN));