Skip to content

V
varnish-cache
Commit 20be063e authored by Poul-Henning Kamp's avatar Poul-Henning Kamp
Browse files
Options

We don't need to use strncpy() when we explicitly checked the 

length already.  (This appearantly confuses Coverity ?)
parent 5e3eb0af
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
bin/varnishd/mgt/mgt_main.c
View file @ 20be063e
...@@ -401,9 +401,9 @@ identify(const char *i_arg) ...@@ -401,9 +401,9 @@ identify(const char *i_arg)
strcpy(id, "varnishd"); strcpy(id, "varnishd");
if (i_arg != NULL) { if (i_arg != NULL) {
if (strlen(i_arg) + 1 >= sizeof heritage.identity) if (strlen(i_arg) + 1 > sizeof heritage.identity)
ARGV_ERR("Identity (-i) name too long.\n"); ARGV_ERR("Identity (-i) name too long.\n");
strncpy(heritage.identity, i_arg, sizeof heritage.identity); strcpy(heritage.identity, i_arg);
i = strlen(id); i = strlen(id);
id[i++] = '/'; id[i++] = '/';
for (; i < (sizeof(id) - 1L); i++) { for (; i < (sizeof(id) - 1L); i++) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment