Commit 3261a9fe authored by Poul-Henning Kamp's avatar Poul-Henning Kamp

We always have a bo->fetch_objcore, don't confuse Coverity with a

NULL test in the middle of things.
parent 0d0a6ce7
......@@ -509,6 +509,7 @@ vbf_stp_fetch(struct worker *wrk, struct busyobj *bo)
CHECK_OBJ_NOTNULL(wrk, WORKER_MAGIC);
CHECK_OBJ_NOTNULL(bo, BUSYOBJ_MAGIC);
CHECK_OBJ_NOTNULL(bo->fetch_objcore, OBJCORE_MAGIC);
assert(wrk->handling == VCL_RET_DELIVER);
......@@ -624,8 +625,7 @@ vbf_stp_fetch(struct worker *wrk, struct busyobj *bo)
if (bo->vfc->failed && !bo->do_stream) {
assert(bo->state < BOS_STREAM);
if (bo->fetch_objcore != NULL)
ObjFreeObj(bo->wrk, bo->fetch_objcore);
ObjFreeObj(bo->wrk, bo->fetch_objcore);
return (F_STP_ERROR);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment