Avoid sideeffects in assert

Spotted by: Coverity

Avoid sideeffects in assert
Spotted by: Coverity
4f03022f · Poul-Henning Kamp · 175e7116 · 4f03022f
Commit 4f03022f authored Feb 13, 2017 by Poul-Henning Kamp
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

cache_shmlog.c bin/varnishd/cache/cache_shmlog.c +2 -1

No files found.
--- a/bin/varnishd/cache/cache_shmlog.c
+++ b/bin/varnishd/cache/cache_shmlog.c
@@ -401,7 +401,8 @@ VSLb_bin(struct vsl_log *vsl, enum VSL_tag_e tag, ssize_t len, const void *ptr)
 	assert(VSL_END(vsl->wlp, len * 2 + 1) < vsl->wle);
 	p = VSL_DATA(vsl->wlp);
 	for (ll = 0; ll < len; ll++) {
-		assert(snprintf(p, 3, "%02x", *pp++) == 2);
+		assert(snprintf(p, 3, "%02x", *pp) == 2);
+		pp++;
 		p += 2;
 	}
 	if (suff)