Notes after another review of restarts changes

75744c85 · Nils Goroll · 6cb21b47 · 75744c85 · 75744c85
Commit 75744c85 authored Nov 08, 2017 by Nils Goroll
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

cache_req.c bin/varnishd/cache/cache_req.c +1 -0

cache_req_fsm.c bin/varnishd/cache/cache_req_fsm.c +4 -0

No files found.
--- a/bin/varnishd/cache/cache_req.c
+++ b/bin/varnishd/cache/cache_req.c
@@ -175,6 +175,7 @@ Req_Release(struct req *req)
 }

 /*----------------------------------------------------------------------
+ * TODO: remove code duplication with cnt_recv_prep
 */

 void

--- a/bin/varnishd/cache/cache_req_fsm.c
+++ b/bin/varnishd/cache/cache_req_fsm.c
@@ -741,6 +741,10 @@ cnt_restart(struct worker *wrk, struct req *req)
 /*
 * prepare the request for vcl_recv, either initially or after a reset
 * e.g. due to vcl switching
+ *
+ * TODO
+ * - make restarts == 0 bit re-usable for rollback
+ * - remove duplicatation with Req_Cleanup()
 */

 static void