Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
varnish-cache
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Commits
Open sidebar
varnishcache
varnish-cache
Commits
77a8b1ac
Commit
77a8b1ac
authored
Oct 23, 2017
by
Dag Haavi Finstad
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Return PROTOCOL_ERROR for END_STREAM + content-length
parent
25897d36
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
23 additions
and
0 deletions
+23
-0
cache_http2_proto.c
bin/varnishd/http2/cache_http2_proto.c
+2
-0
r02305.vtc
bin/varnishtest/tests/r02305.vtc
+21
-0
No files found.
bin/varnishd/http2/cache_http2_proto.c
View file @
77a8b1ac
...
...
@@ -531,6 +531,8 @@ h2_end_headers(struct worker *wrk, struct h2_sess *h2,
req
->
req_body_status
=
REQ_BODY_WITH_LEN
;
}
else
{
assert
(
req
->
req_body_status
==
REQ_BODY_NONE
);
if
(
http_GetContentLength
(
req
->
http
)
>
0
)
return
(
H2CE_PROTOCOL_ERROR
);
//rfc7540,l,1838,1840
}
req
->
req_step
=
R_STP_TRANSPORT
;
...
...
bin/varnishtest/tests/r02305.vtc
View file @
77a8b1ac
...
...
@@ -45,6 +45,27 @@ client c1 {
} -run
} -run
client c2 {
stream 1 {
txreq -hdr "content-length" "23"
} -run
stream 0 {
rxgoaway
expect goaway.err == PROTOCOL_ERROR
expect goaway.laststream == 1
} -run
} -run
# Allow content-length: 0
client c2 {
stream 1 {
txreq -hdr "content-length" "0"
rxresp
expect resp.status == 200
} -run
} -run
varnish v1 -vsl_catchup
varnish v1 -expect MEMPOOL.req0.live == 0
varnish v1 -expect MEMPOOL.sess0.live == 0
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment