Always wrap code-generating macros in do { ... } while(0)

825e5b2d · Poul-Henning Kamp · eb56e6df · 825e5b2d
Commit 825e5b2d authored Aug 30, 2021 by Poul-Henning Kamp
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

cache_http2_panic.c bin/varnishd/http2/cache_http2_panic.c +6 -4

No files found.
--- a/bin/varnishd/http2/cache_http2_panic.c
+++ b/bin/varnishd/http2/cache_http2_panic.c
@@ -51,10 +51,12 @@ h2_panic_settings(struct vsb *vsb, const struct h2_settings *s)
 	int cont = 0;

 #define H2_SETTING(U,l,...)			\
-	if (cont)				\
-		VSB_printf(vsb, ", ");		\
-	cont = 1;				\
-	VSB_printf(vsb, "0x%x", s->l);
+	do {					\
+		if (cont)			\
+			VSB_printf(vsb, ", ");	\
+		cont = 1;			\
+		VSB_printf(vsb, "0x%x", s->l);	\
+	} while (0);
 #include "tbl/h2_settings.h"
 #undef H2_SETTING
 }