Skip to content

V
varnish-cache
Commit c1aa3c20 authored by Poul-Henning Kamp's avatar Poul-Henning Kamp
Browse files
Options

Proper locking around n_backend. Found by Coverity.

parent e0d796b6
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 1 deletion
vmod/vmod_directors.c
View file @ c1aa3c20
...@@ -94,9 +94,11 @@ vdir_release(struct vdir *vd) ...@@ -94,9 +94,11 @@ vdir_release(struct vdir *vd)
CHECK_OBJ_NOTNULL(vd, VDIR_MAGIC); CHECK_OBJ_NOTNULL(vd, VDIR_MAGIC);
vdir_wrlock(vd);
for (u = 0; u < vd->n_backend; u++) for (u = 0; u < vd->n_backend; u++)
VRT_Assign_Backend(&vd->backend[u], NULL); VRT_Assign_Backend(&vd->backend[u], NULL);
vd->n_backend = 0; vd->n_backend = 0;
vdir_unlock(vd);
} }
void void
......
vmod/vmod_directors_round_robin.c
View file @ c1aa3c20
...@@ -90,9 +90,9 @@ vmod_rr_resolve(VRT_CTX, VCL_BACKEND dir) ...@@ -90,9 +90,9 @@ vmod_rr_resolve(VRT_CTX, VCL_BACKEND dir)
break; break;
} }
rr->nxt = nxt; rr->nxt = nxt;
vdir_unlock(rr->vd);
if (u == rr->vd->n_backend) if (u == rr->vd->n_backend)
be = NULL; be = NULL;
vdir_unlock(rr->vd);
return (be); return (be);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment