Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
varnish-cache
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Commits
Open sidebar
varnishcache
varnish-cache
Commits
cbf01b23
Commit
cbf01b23
authored
Jan 29, 2024
by
Dridi Boukelmoune
Committed by
Simon Stridsberg
Mar 18, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
http2_send: Explain the winup-open discrepancy
parent
cc5f7e7a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
12 additions
and
0 deletions
+12
-0
cache_http2_send.c
bin/varnishd/http2/cache_http2_send.c
+12
-0
No files found.
bin/varnishd/http2/cache_http2_send.c
View file @
cbf01b23
...
...
@@ -285,6 +285,18 @@ h2_do_window(struct worker *wrk, struct h2_req *r2,
assert
(
w
>
0
);
}
/* If all streams ran out of control flow window credits
* upon triggering h2_window_timeout, declare bankruptcy
* for the entire connection.
*
* But streams may be closed from the h2_sess thread while
* waiting for a window update. So the open_streams counter
* may be decremented in a different critical section than
* winup_streams, right before signalling the stream thread.
* So there may be more streams awaiting a window updates
* than streams officially open, hence the "lower-equal"
* comparison.
*/
if
(
r2
->
error
==
H2SE_BROKE_WINDOW
&&
h2
->
open_streams
<=
h2
->
winup_streams
)
h2
->
error
=
r2
->
error
=
H2CE_BANKRUPT
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment