directors: Missing shard error handling

Spotted by Coverity.

directors: Missing shard error handling
Spotted by Coverity.
d2fd7b60 · Dridi Boukelmoune · 303ff55a · d2fd7b60
Commit d2fd7b60 authored Oct 11, 2020 by Dridi Boukelmoune
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

shard_cfg.c lib/libvmod_directors/shard_cfg.c +4 -0

No files found.
--- a/lib/libvmod_directors/shard_cfg.c
+++ b/lib/libvmod_directors/shard_cfg.c
@@ -109,6 +109,10 @@ shard_change_get(VRT_CTX, struct sharddir * const shardd)
 	CHECK_OBJ_NOTNULL(ctx, VRT_CTX_MAGIC);

 	task = VRT_priv_task(ctx, id);
+	if (task == NULL) {
+		shard_fail(ctx, shardd->name, "%s", "no priv_task");
+		return (NULL);
+	}

 	if (task->priv != NULL) {
 		CAST_OBJ_NOTNULL(change, task->priv, SHARD_CHANGE_MAGIC);