No return value from VTCP_[non]blocking() to throw away

bin/varnishd/cache/cache_acceptor.c

@@ -382,7 +382,7 @@ vca_make_session(struct worker *wrk, void *arg)
 		 * to send an intelligent message back.
 		 */
 		vca_pace_bad();
-		(void)VTCP_nonblocking(wa->acceptsock);
+		VTCP_nonblocking(wa->acceptsock);
 		closefd(&wa->acceptsock);
 		wrk->stats->sess_drop++;
 		WS_Release(wrk->aws, 0);

bin/varnishd/http1/cache_http1_fetch.c

@@ -98,7 +98,7 @@ V1F_SendReq(struct worker *wrk, struct busyobj *bo, uint64_t *ctr_hdrbytes,
 
 	VSLb(bo->vsl, SLT_BackendStart, "%s %s", abuf, pbuf);
 
-	(void)VTCP_blocking(*htc->rfd);	/* XXX: we should timeout instead */
+	VTCP_blocking(*htc->rfd);	/* XXX: we should timeout instead */
 	V1L_Open(wrk, wrk->aws, htc->rfd, bo->vsl, bo->t_prev, 0);
 	hdrbytes = HTTP1_Write(wrk, hp, HTTP1_Req);
 

bin/varnishd/http2/cache_http2_proto.c

@@ -1076,7 +1076,7 @@ h2_rxframe(struct worker *wrk, struct h2_sess *h2)
 	char b[8];
 
 	ASSERT_RXTHR(h2);
-	(void)VTCP_blocking(*h2->htc->rfd);
+	VTCP_blocking(*h2->htc->rfd);
 	h2->sess->t_idle = VTIM_real();
 	hs = HTC_RxStuff(h2->htc, h2_frame_complete,
 	    NULL, NULL, NAN,

bin/varnishtest/vtc_barrier.c

@@ -147,7 +147,7 @@ barrier_sock_thread(void *priv)
 		    b->name, err, strerror(errno), errno);
 	}
 	assert(sock > 0);
-	(void)VTCP_nonblocking(sock);
+	VTCP_nonblocking(sock);
 	VTCP_myname(sock, abuf, sizeof abuf, pbuf, sizeof pbuf);
 
 	macro_def(vl, b->name, "addr", "%s", abuf);

bin/varnishtest/vtc_client.c

@@ -140,7 +140,7 @@ uds_open(void *priv, const struct sockaddr_un *uds)
 	if (s < 0)
 		return (s);
 
-	(void) VTCP_nonblocking(s);
+	VTCP_nonblocking(s);
 	i = connect(s, (const void*)uds, sl);
 	if (i == 0)
 		return(s);
@@ -221,7 +221,7 @@ client_thread(void *priv)
 			vtc_fatal(c->vl, "Failed to open %s: %s",
 			    VSB_data(vsb), err);
 		/* VTCP_blocking does its own checks, trust it */
-		(void)VTCP_blocking(fd);
+		VTCP_blocking(fd);
 		if (c->proxy_spec != NULL)
 			client_proxy(vl, fd, c->proxy_version, c->proxy_spec);
 		if (! c->keepalive)

bin/varnishtest/vtc_haproxy.c

@@ -303,7 +303,7 @@ haproxy_cli_thread(void *priv)
 	if (fd < 0)
 		vtc_fatal(hc->vl,
 		    "CLI failed to open %s: %s", VSB_data(vsb), err);
-	(void)VTCP_blocking(fd);
+	VTCP_blocking(fd);
 	hc->sock = fd;
 	parse_string(hc->spec, haproxy_cli_cmds, hc, hc->vl);
 	vtc_log(hc->vl, 2, "CLI ending");

bin/varnishtest/vtc_subr.c

@@ -193,7 +193,7 @@ vtc_record(struct vtclog *vl, int fd, struct vsb *vsb)
 	struct pollfd fds[1];
 	int i;
 
-	(void)VTCP_nonblocking(fd);
+	VTCP_nonblocking(fd);
 	while (1) {
 		memset(fds, 0, sizeof fds);
 		fds->fd = fd;

lib/libvarnish/vtcp.c

@@ -265,7 +265,7 @@ VTCP_connected(int s)
 		return (-1);
 	}
 
-	(void)VTCP_blocking(s);
+	VTCP_blocking(s);
 	return (s);
 }
 
@@ -292,7 +292,7 @@ VTCP_connect(const struct suckaddr *name, int msec)
 
 	/* Set the socket non-blocking */
 	if (msec != 0)
-		(void)VTCP_nonblocking(s);
+		VTCP_nonblocking(s);
 
 	val = 1;
 	AZ(setsockopt(s, IPPROTO_TCP, TCP_NODELAY, &val, sizeof val));

lib/libvarnish/vus.c

@@ -119,7 +119,7 @@ VUS_connect(const char *path, int msec)
 
 	/* Set the socket non-blocking */
 	if (msec != 0)
-		(void)VTCP_nonblocking(s);
+		VTCP_nonblocking(s);
 
 	i = connect(s, (const void*)&uds, sl);
 	if (i == 0)