Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
varnish-cache
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Commits
Open sidebar
varnishcache
varnish-cache
Commits
ded79885
Commit
ded79885
authored
Oct 05, 2018
by
Dridi Boukelmoune
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix assertion for PUSH_PROMISE frames
r2 can be either null or not. Test case by @daghf Refs #2781
parent
413cbd44
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
1 deletion
+16
-1
cache_http2_proto.c
bin/varnishd/http2/cache_http2_proto.c
+1
-1
t02003.vtc
bin/varnishtest/tests/t02003.vtc
+15
-0
No files found.
bin/varnishd/http2/cache_http2_proto.c
View file @
ded79885
...
...
@@ -305,7 +305,7 @@ h2_rx_push_promise(struct worker *wrk, struct h2_sess *h2, struct h2_req *r2)
CHECK_OBJ_NOTNULL
(
wrk
,
WORKER_MAGIC
);
ASSERT_RXTHR
(
h2
);
CHECK_OBJ_
NOTNULL
(
r2
,
H2_REQ_MAGIC
);
/* XXX: wasteful allocation? */
CHECK_OBJ_
ORNULL
(
r2
,
H2_REQ_MAGIC
);
// rfc7540,l,2262,2267
return
(
H2CE_PROTOCOL_ERROR
);
}
...
...
bin/varnishtest/tests/t02003.vtc
View file @
ded79885
...
...
@@ -173,6 +173,21 @@ client c1 {
stream 0 -wait
} -run
client c1 {
stream 0 {
rxgoaway
expect goaway.err == PROTOCOL_ERROR
expect goaway.laststream == 1
} -start
stream 1 {
txreq
rxresp
delay .1
# send a PUSH_PROMISE after a request
sendhex "000008 05 00 00000001 0001020304050607"
} -start
} -run
varnish v1 -vsl_catchup
varnish v1 -expect MEMPOOL.req0.live == 0
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment