Add support for using this if it is defined by the administrator
in the /etc/sysconfig/varnish file.

From way back we've had a commented-out DAEMON_COREFILE_LIMIT in
our /etc/sysconfig/varnish file, which wasn't referenced anywhere.

Suggested by: gaoyongwei/itxx00 on github.

Suggested by:	Steven Engelhardt via github

This to give predictable backend reuse behavior for varnishtest,
making the test cases non-racy.

2nd version of this patch. This version will only deal with recyclable
backend connections before BOS_FINISHED, leaving the slower close path
to the clean up code that is run after the BOS_FINISHED state.

Fixes: #1491

instances whenever we give the server instance more work, doing
so runs into a dark and murky corner somewhere in Stevens and
Solaris sometimes doesn't like that.

The trouble is that the initial bind(2) asks the kernel to assign
a port, but the subsequent insist on reusing that port, and that,
in some cases, could mean toruble which cannot be allowed.

Add a "-break" instruction to server so that test case c00035 can
still work.

Spotted by:	Nils Goroll / UPLEX

Update changelog

Submitted by:	github::brianjarita

As discussed on bugwash today. Lowering the bar may help us improve the
documentation.

The pool herder didn't signal the thread when decimating the flock,
causing the thread to be leaked.

Spotted by: xcir
Fixes: #1490

Also close a couple of other races:

When pthread_cond_timedwait returns ETIMEDOUT, the predicate
(wrk->task.func == NULL) could still have changed while reacquiring
the mutex. If so, the signal would've been lost and the thread
leaked. Changed the idle wait loop in Pool_Work_Thread() to always
check the predicate before resuming the cond_wait.

The update of the predicate (wrk->task.func) from e.g. Pool_Task() is
done without holding the mutex. This opens a race on the predicate,
and the possibility of the worker going back on cond_wait loosing the
signal. Changed to update the predicate while holding the mutex.

Spotted by:	Coverity

Spotted by:	Coverity

In 4.x we changed obj.hits to be read-only, and to count all variants
under the same hash-key (= same objhdr).

Since we cannot trivially tell if a ban hits all Vary: values or
just some of them, there is no sane heuristic to fiddle obj.hits
on bans that would Do The Right Thing.

Fixes #1492

Also remove the libvarnishapi "workaround" we put in place
earlier.

Found by: Ingvar Hagelund

Fixes: #1484

Fixes: #1489
Spotted by: xcir

Update board members, URLs, spelling and fmt(1).

The disembarking thread would clear the req->wrk pointer in
CNT_Request. The req could have already been rescheduled on another
worker at this point, causing the req->wrk to be cleared while
processing. Change back to not clearing the pointer for
REQ_FSM_DISEMBARK (it's already been done under mutex in HSH_Lookup
anyways).

Fixes: #1488

backend IMS.

When revalidating using backend IMS, copy the status code, status
code, status string and response message from the original object into
the new revalidated object. This makes sure that none of the 304
message fields gets applied to the new revalidated object.

Fixes: #1485

The Age reported on response objects is calculated from the last
request timestamp taken. For a cache hit that hasn't been on a
waitinglist, that will be the Start timestamp. This opens a race where
the requests' last timestamp could be before the objects t_origin.

Truncate the Age to zero rather than assert in that case.

Fixes: #1486

If one runs configure with --without-rst2man or no rst2man is found,
the value is "no", not an empty string.  Handle this correctly in
configure.

Fixes: #1473

specific user and/or group may execute it. Varnish never inherited
the groups of the user that has been specified by "-u". initgroups()
will make sure that varnish gets all supplementary groups.

Submitted by:	Christian Ruppert
Fixes	#1482

who made them with Coccinelle.

Thanks!

Fixes #1480