- 31 Jan, 2023 2 commits
-
-
Walid Boudebouda authored
This will be useful as varnishtest will honor more settings. Signed-off-by: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>
-
Walid Boudebouda authored
It groups the ws and iws fields together and hopefully conveys that h2_window::init means "initial window size" slightly better than iws. Signed-off-by: Dridi Boukelmoune <dridi.boukelmoune@gmail.com>
-
- 30 Jan, 2023 10 commits
-
-
Dridi Boukelmoune authored
This fields were never set in the first place so they went away in #3888. We don't have SunOS coverage on Github so I noticed it after the facts. I did look at the Solaris jail but somehow missed that those fields were used there as well. Chances are that the deleted statements never ran in the first place, otherwise the assertions would have triggered. If the solaris jail should set[gu]id(2) as part of its privileges drop, it should probably grow new sub-options similar to the ones in the unix jail. Refs #3888
-
Dridi Boukelmoune authored
This aligns with varnishd where durations are always computed in seconds instead of introducing corner cases where sometimes it's milliseconds. It also aligns with vtc_syslog that was introduced after the change to "seconds everywhere" in varnishd.
-
Dridi Boukelmoune authored
We already pass it to VEV and VCLI subsystems in places where a double is expected. Trivia: we currently parse it in two distinct ways. So for now I'm not eager to support duration units.
-
Dridi Boukelmoune authored
They are shared with the cache process but are never used. Only the VCC process uses them, but they are never set. This specific fchown(2) call in the VCC process was probably a no-op in the first place: since the fields are never set this is transferring ownership to root:root and if that succeeded the process was already root in the first place. If it failed, we never see the error message since we lacked root privileges. Both the unix and solaris jails are designed to run VCC (and CC) with limited privileges, and in the absence of a jail, the outcome should be the same: VCC creates a file with credentials suitable for the next CC invocation.
-
Dridi Boukelmoune authored
As I suspected, the -Werror setup for libvgz C flags were needed to properly discard them for suncc. Both warnings are conditionally not turned into errors, so -Wno-unknown-warning-option should no longer be needed. Refs madler/zlib#633
-
Dridi Boukelmoune authored
Trying to fix the build for clang 15 actually broke the build for GCC. The -Werror that was initially set after saving CFLAGS was meant to be part of NO_VIZ test. We turn warnings into errors later in the configure script so at this point we shouldn't care about it. If we really do, we can move this check below the line where -Werror is set. GCC chokes on -Wno-error=deprecated-non-prototype so instead we add it conditionally. To match the naming convention everywhere else, libvgz_extra_cflags was renamed to VGZ_CFLAGS. Refs 118fd10c
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
There are two warnings that we enforce for our own code that zlib does not. There's also the visibility attribute that we check at configure time. And regarding the visibility attribute, zlib no longer relies on a NO_VIZ macro and aligned with the autoconf naming convention and wants HAVE_HIDDEN instead.
-
Dridi Boukelmoune authored
-
Poul-Henning Kamp authored
Spotted by: Coverity
-
- 24 Jan, 2023 1 commit
-
-
Dridi Boukelmoune authored
Spotted by our Alpine Linux job on CircleCI.
-
- 23 Jan, 2023 2 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 18 Jan, 2023 4 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
- 17 Jan, 2023 3 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Poul-Henning Kamp authored
Change CLI cmd debug.xid to set the next XID to be used, rather than "one less than the next XID to be used"
-
- 16 Jan, 2023 4 commits
-
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
Opportunity noticed during the review of #3872.
-
Gil Pedersen authored
-
Gil Pedersen authored
This is an enhanced fix for #1777
-
- 12 Jan, 2023 1 commit
-
-
Poul-Henning Kamp authored
-
- 19 Dec, 2022 2 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 13 Dec, 2022 3 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
Fixes #3882
-
- 12 Dec, 2022 2 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
- 08 Dec, 2022 2 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
Otherwise a long banner may throw expectations off by one line. Fixes #3877
-
- 06 Dec, 2022 4 commits
-
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
Neither Martin nor I can remember why this was uintptr_t in the first place, and there is no signs of pointers anywhere nearby.
-