- 20 Dec, 2019 6 commits
-
-
Guillaume Quintard authored
-
Guillaume Quintard authored
-
Martin Blix Grydeland authored
Log a notice message when delaying a conditional fetch and the stale template object is still streaming.
-
Martin Blix Grydeland authored
This VSL tag will be used for informational messages related to exceptional handling of requests.
-
Martin Blix Grydeland authored
Wait for the stale object to become fully fetched, so that we can catch fetch errors, before we unbusy the new object. This serves two purposes. First it helps with request coalescing, and stops long chains of IMS-updated short-TTL objects all streaming from a single slow body fetch. Second it makes sure that all the object attributes are complete when we copy them (this would be an issue for ie OA_GZIPBITS). This patch OBE's r01646.vtc, and slightly patches r01648.vtc to expect a 503 instead of a 200 and a broken connection on the failing client. Fixes: #3089
-
Dridi Boukelmoune authored
The code base and documentation refer to ``sub`` symbols as: - subroutines - functions - methods - procedures - callbacks This change focuses on always referring to them as subroutines in the documentation. During this documentation sweep, there were a lot of false positives since VCL, VMODs and HTTP also share that vocabulary and I may have missed false negatives, especially for generated bits of documentation. Some parts of the documentation were not touched on purpose: upgrade notes and changelogs of past releases, PHK random outbursts, etc. Now that the documentation is hopefully taken care of the same needs to happen in the code base, starting with user-facing error messages and then data structures names, function names etc. There will be however one exception. Anything referring to the scope of a subroutine, but being worded as if it referred to the subroutine itself will use scope instead. As this will touch a lot of code, it will be done incrementally, much like this change focused on non-generated documentation (and VCC files don't count as generated in this context). I also fixed RST formatting issues I noticed during my sweep. Better diff with the --word-diff --ignore-all-space options.
-
- 19 Dec, 2019 4 commits
-
-
Nils Goroll authored
as promised in #3161
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
Notice: The boolean expression does not lack parantheses, the test for generate.py is only to be and'ed with the test for .git Fixes #3165
-
- 18 Dec, 2019 1 commit
-
-
Dridi Boukelmoune authored
Before: ...called from "foo" ('<vcl.inline>' Line 5 Pos 27) sub bar { call foo; } --------------------------#-- After: ...called from "bar" ('<vcl.inline>' Line 5 Pos 24) sub bar { call foo; } -----------------------###--- This fixes the "called from" part of the message to refer to the caller instead of the callee, and underlines the symbol token instead of the semi-colon.
-
- 17 Dec, 2019 3 commits
-
-
Dridi Boukelmoune authored
-
Nils Goroll authored
We had two places where we documented common actions, and one of them was outdated.
-
Nils Goroll authored
...even after ~11 years of experience with varnish. today: return without an action from a custom subroutine.
-
- 16 Dec, 2019 14 commits
-
-
Nils Goroll authored
-
Nils Goroll authored
it is not before we have parsed parameters
-
Nils Goroll authored
Fixes #3160
-
Dridi Boukelmoune authored
Spotted via vtest: l1 timed out despite varnishd logging what was expected next. This is tightening l1's expectation in the hope that r2339 will no longer flake. I wasn't able to reproduce this even on my vtest box where it failed.
-
Nils Goroll authored
-
Nils Goroll authored
-
Dridi Boukelmoune authored
-
Nils Goroll authored
-
Nils Goroll authored
we already check for unused subs in vcc_checkref() Fixes #3159
-
Nils Goroll authored
-
Nils Goroll authored
$ nslookup dns-canary.freebsd.dk Non-authoritative answer: *** Can't find dns-canary.freebsd.dk: No answer if anyone has a more reliable server to test, please just change it again.
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
- 15 Dec, 2019 1 commit
-
-
Nils Goroll authored
-
- 13 Dec, 2019 4 commits
-
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
Ref #2575
-
Dridi Boukelmoune authored
Under stress we might otherwise check n_objectcore before it gets a chance to decrease completely. Spotted via vtest.
-
- 12 Dec, 2019 4 commits
-
-
Nils Goroll authored
This test was failing before silently: It seems these vtest machines do not resolve localhost to the address passed as the localhost define to vtest, so use the latter in order to stabilize.
-
Nils Goroll authored
-
Nils Goroll authored
I should have included the netnotation right away
-
Nils Goroll authored
-
- 11 Dec, 2019 3 commits
-
-
Dridi Boukelmoune authored
Every time I read this code I fail to remember which symbol is which, so from now on the instance symbol will be called isym, the object symbol osym and the method symbols msym.
-
Dridi Boukelmoune authored
They fit within 80 columns.
-
Dridi Boukelmoune authored
Instead, the comma is emitted when there is indeed an extra argument. This change was initially submitted in #3147 and is needed when the extra argument may vary for a given symbol. More specifically, when a method symbol may be shared by several instance symbols, it becomes really difficult to find a spot where that extra comma might be added. Removing it from the extra argument itself makes this easier once we reach the point where method symbols are unique (per object) instead of repeated (per instance).
-