- 12 Feb, 2019 4 commits
-
-
Nils Goroll authored
Ref #2743
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
see 11 lines down Conflicts: bin/varnishd/cache/cache_hash.c
-
- 08 Feb, 2019 36 commits
-
-
Dag Haavi Finstad authored
req's on waiting list do indeed hold an objhead ref (req->hash_objhead), so the condition for the while loop in hsh_deref_objhead_unlock will always evaluate to false. This gets rid of the needless rushing code and replaces it with an assert.
-
Poul-Henning Kamp authored
Simplify the !busy cases Inspired by: #2856
-
Poul-Henning Kamp authored
Use req->hash_always_miss directly Inspired by: #2856
-
Poul-Henning Kamp authored
Refactor the hit-cases Inspired by: #2856
-
Poul-Henning Kamp authored
Move successful loop termination out of the loop. Inspired by: #2856
-
Poul-Henning Kamp authored
-
Dridi Boukelmoune authored
-
Martin Blix Grydeland authored
Make use of the new hsh_deref_objhead_unlock() in HSH_Lookup() to reduce the number of times the objhead mutex is taken during cache hits.
-
Martin Blix Grydeland authored
Split hsh_deref_objhead() into two parts, with the new hsh_deref_objhead_unlock() function expecting a locked objhead reference on input.
-
Martin Blix Grydeland authored
Make this function lower case for consistency.
-
Martin Blix Grydeland authored
This changes the hash slingers deref function to take a locked objhead on input, and unlocking it before returning. This saves a lock/unlock sequence for critbit (which is the critical one) on HSH_DerefObjHead.
-
Martin Blix Grydeland authored
Move the clean up call to HSH_DeleteObjHead inside of the hash deref methods that require it, instead of having the outside (single) caller do it based off the return value. This just cleans up and makes the logic more transparent.
-
Nils Goroll authored
This is caught by assert(lr == HSH_HIT || lr == HSH_GRACE); in cnt_lookup()
-
Nils Goroll authored
Closes #2743 Conflicts: doc/changes.rst doc/changes.rst was considered binary in master, it won't be in 6.0 so there will be no need to pick a1d2db69 too. Refs a1d2db69
-
Nils Goroll authored
in particular, move logging
-
Nils Goroll authored
-
Nils Goroll authored
they are the same case
-
Nils Goroll authored
Now that we got hit-for-pass (hfp) and hit-for-miss (hfm), we should name the latter consistently to avoid unnecessary confusion
-
Dag Haavi Finstad authored
Conflicts: lib/libvarnishapi/vsl_arg.c For some reason it was missing errno.h...
-
Dridi Boukelmoune authored
A vmod may return a null IP. This relaxes the check in VRT_acl_match to fail the transaction instead of crashing. Refs #2842
-
Dag Haavi Finstad authored
-
Nils Goroll authored
Inclused re-declaration fixes for some places which I got wrong in the past. Conflicts: bin/varnishd/cache/cache_objhead.h
-
Lasse Karstensen authored
-
Lasse Karstensen authored
-
Lasse Karstensen authored
This is a squashed commit including lint removal and formatting suggested by @nigoroll.
-
Poul-Henning Kamp authored
-
Nils Goroll authored
The vmod name got lost in e7c04974 example before/after diff: - new xshard_param = shard_param() + new xshard_param = directors.shard_param()
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
Partially addresses #2846. I've avoided mentioning NULL on purpose as it's not really meaningful nor accessible from VCL. ymmv.
-
Lasse Karstensen authored
Pedantic back-port note: those are acronyms.
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
Add tests for vcl_keep and move vmod_so_keep together. Reported and diagnosed by jw @ irc.
-
Federico G. Schwindt authored
Enabled when using varnishtest -L.
-
Nils Goroll authored
this would have caught 7395ecae
-