1. 11 Oct, 2019 4 commits
    • Nils Goroll's avatar
      fix glitch from previous · 66702575
      Nils Goroll authored
      Ref #3088
      
      apparently the additional argument was just silently tolerated by
      varnishtest
      66702575
    • Nils Goroll's avatar
      test that varnish{top,stat,hist} properly handle signals · 5362e729
      Nils Goroll authored
      Tests #3088
      5362e729
    • Nils Goroll's avatar
      fix signal handling in varnishtop and varnishhist · 47579871
      Nils Goroll authored
      Using vut->last_sighup was not adequate, because the VUT_Main loop might
      have terminated for some other signal or because of EOF.
      
      On the other hand, we do not want to end the curses loop just because
      the VUT_Main loop has ended in order to continue to display the last
      state (and maybe the EOF in the top right corner).
      
      So while I see that checking just one flag has some beauty to it, I do
      think that directly checking the signal counters is both simple and
      robust.
      
      Fixes #3088 for varnishtop and varnishhist
      47579871
    • Nils Goroll's avatar
      signal handling for varnishstat in curses mode · 6c510ef7
      Nils Goroll authored
      Fixes #3088 for varnishstat
      
      note that besides handling SIGHUP, this also adds handling of SIGTERM
      and SIGINT, which were also missing.
      6c510ef7
  2. 09 Oct, 2019 6 commits
  3. 08 Oct, 2019 2 commits
  4. 07 Oct, 2019 6 commits
    • Nils Goroll's avatar
      fix bereq rollback · 7d25b83b
      Nils Goroll authored
      by properly cleaning up the busyobj
      
      Also move the relevant code from cache_vrt.c to cache_fetch.c
      
      As we fini the director during cleanup, we now also need to handle the
      backend connection gone missing in vbf_stp_fetch(). The hypothetical
      alternative would be to not fini the director, but I believe this is not
      safe in case it also used some workspace.
      
      Fixes #3009
      7d25b83b
    • Nils Goroll's avatar
      add test case by @rezan · 0ed38379
      Nils Goroll authored
      0ed38379
    • Nils Goroll's avatar
      also reset filter_list upon cleanup · e2b43f86
      Nils Goroll authored
      in particular because it may live on the workspace.
      
      Required for #3009
      e2b43f86
    • Nils Goroll's avatar
      centralize cleanup after fetch errors · bbd4c476
      Nils Goroll authored
      imples the following changes:
      
      * VDI_Finish() is now always conditional on bo->director_state !=
        DIR_S_NULL, making it idempotent
      
      * introduces additional calls to VFP_Close() from startfetch and
        for the filter_list / VCL_StackVFP error in vbf_stp_fetch(),
        but VFP_Close() is idempotent.
      
      * adds VFP_Close() for VFP_Open() failure in vbf_stp_fetch() which
        I think is actually missing (for the case that some VFPs could
        get opened before the open failure)
      
      * calls VDI_Finish() earlier in vbf_stp_fetchend: I checked the
        code and can not see any issue with this.
      
      motivated by #3009
      bbd4c476
    • Nils Goroll's avatar
      make VFP_Close() idempotent · ecfd1eb0
      Nils Goroll authored
      required for #3009
      ecfd1eb0
    • Jordan Christiansen's avatar
      0ba4d294
  5. 04 Oct, 2019 1 commit
  6. 03 Oct, 2019 2 commits
  7. 02 Oct, 2019 1 commit
  8. 01 Oct, 2019 1 commit
  9. 30 Sep, 2019 8 commits
  10. 29 Sep, 2019 1 commit
  11. 28 Sep, 2019 1 commit
  12. 27 Sep, 2019 3 commits
  13. 25 Sep, 2019 1 commit
  14. 24 Sep, 2019 1 commit
  15. 23 Sep, 2019 2 commits