1. 02 Jul, 2021 1 commit
    • Jordan Christiansen's avatar
      circleci: Re-enable Alpine latest · 7795c2b3
      Jordan Christiansen authored
      Alpine 3.14 includes a newer version of musl that uses the newer
      faccessat2 syscall, which is not yet allowlisted by the seccomp filter
      in older Docker versions. Docker 20.10.0+ allows this new syscall.
      
      In this patch, we configure Circle to set up a Docker 20.10+ environment
      where we can run Alpine 3.14 builds.
      7795c2b3
  2. 30 Jun, 2021 4 commits
  3. 29 Jun, 2021 2 commits
  4. 28 Jun, 2021 2 commits
  5. 27 Jun, 2021 4 commits
    • Dridi Boukelmoune's avatar
      vtc: Stabilize and reorganize b15 · 121356d9
      Dridi Boukelmoune authored
      While in itself this is not a slow test, on a loaded system the
      connection failures can degrade the run time dramatically, like 20
      times slower.
      
      To save some time here and there, some client sessions were folded
      together where it made sense. Also no two clients share the same name
      to make it easier to spot the offending one in a test log.
      
      More importantly, the holddown test at the end which concerns the very
      first VCL is now put at the beginning where it belongs, and also where
      tweaking backend_remote_error_holddown will actually have the desired
      effect.
      121356d9
    • Dridi Boukelmoune's avatar
      vtc: Stabilize s6 · 3dcb2a50
      Dridi Boukelmoune authored
      Despite 1s of delay we sometimes observe a zero Age header, which is
      consistent with being under the max-age of 2s and should not fail.
      3dcb2a50
    • Dridi Boukelmoune's avatar
      vtc: Stabilize d3 · 3cb7f80c
      Dridi Boukelmoune authored
      There's always the possibility to fail reusing s2's first connection
      after it was closed.
      3cb7f80c
    • Dridi Boukelmoune's avatar
      vtc: Stabilize c93 · 97afc52e
      Dridi Boukelmoune authored
      On a loaded system the delay may not be enough, a barrier should.
      97afc52e
  6. 24 Jun, 2021 2 commits
  7. 23 Jun, 2021 4 commits
    • Dridi Boukelmoune's avatar
      f1e86c86
    • Dridi Boukelmoune's avatar
      varnishtest: Teach logexpect to stop with the vtc · 1ccba721
      Dridi Boukelmoune authored
      With a non-deterministic `expect * * ...` the logexpect thread would
      never consider itself to be done if the vtc ends if one entry was not
      seen in the vsl.
      1ccba721
    • Dridi Boukelmoune's avatar
      varnishtest: Make barriers reactive on error · 3c67da44
      Dridi Boukelmoune authored
      A failing test may take up to the vtc timeout to effectively fail if a
      thread is waiting for a barrier to sync. Barriers now check every 100ms
      whether the vtc is done to bail out.
      
      The socket barriers were already polling for 1s, so now they poll for
      100ms and leave the loop early when needed.
      
      The condvar barriers now loop over a timedwait, but critical sections
      were too wide. There were vtc_fatal() calls under barrier locks that
      would defeat the timedwait loop.
      
      Thus critical sections were more carefully laid, allowing multiple
      barrier commands to run simultaneously. This also means that besides
      initialization, socket barriers no longer touch the lock.
      
      Consider the following diff:
      
          --- bin/varnishtest/tests/v00056.vtc
          +++ bin/varnishtest/tests/v00056.vtc
          @@ -72,7 +72,7 @@ client c2 {
           } -run
      
           logexpect l2 -v v1 -g raw -q Backend_health {
          -       expect 0 0 Backend_health "default Went healthy"
          +       expect 0 0 Backend_health "default Went wrong"
           } -start
      
           barrier b3 sync
      
      With this change l2 would fail early, typically in less than 2s, but the
      barriers stuck in a condwait would prevent further progress.
      3c67da44
    • Guillaume Quintard's avatar
      [cci] refactor · 7b422447
      Guillaume Quintard authored
      7b422447
  8. 22 Jun, 2021 3 commits
  9. 21 Jun, 2021 3 commits
  10. 18 Jun, 2021 2 commits
  11. 17 Jun, 2021 3 commits
  12. 14 Jun, 2021 3 commits
    • Dridi Boukelmoune's avatar
      req: New hash_ignore_vary flag · badee461
      Dridi Boukelmoune authored
      It works like the hash_ignore_busy flag: it is disabled by default
      and survives a restart, but as the name implies will skip vary checks
      for object candidates.
      badee461
    • Nils Goroll's avatar
      Fail the vcl for hard pcre errors · bd36ad4d
      Nils Goroll authored
      When a regex match failed with a hard error (anything which is not just
      a "no match"), we would log a VCL_Error but otherwise just fail the
      match.
      
      Thus, such failures were likely go remain unnoticed, which could have
      serious implications in particular with negated matches.
      
      Ref 6c663836
      bd36ad4d
    • Poul-Henning Kamp's avatar
      Always assert VSB_finish() · 5fd49a1b
      Poul-Henning Kamp authored
      Spotted by: Coverity
      5fd49a1b
  13. 13 Jun, 2021 1 commit
    • Federico G. Schwindt's avatar
      Fix compilation on macOS Big Sur · 2ac27056
      Federico G. Schwindt authored
      Fixes:
      
      In file included from vev.c:36:
       /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/pthread.h:328:6: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined]
       #if !_PTHREAD_SWIFT_IMPORTER_NULLABILITY_COMPAT
            ^
       /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/pthread.h:197:2: note: expanded from macro '_PTHREAD_SWIFT_IMPORTER_NULLABILITY_COMPAT'
               defined(SWIFT_CLASS_EXTRA) && (!defined(SWIFT_SDK_OVERLAY_PTHREAD_EPOCH) || (SWIFT_SDK_OVERLAY_PTHREAD_EPOCH < 1))
      2ac27056
  14. 11 Jun, 2021 5 commits
  15. 10 Jun, 2021 1 commit