- 03 Apr, 2019 2 commits
-
-
Dridi Boukelmoune authored
-
Dridi Boukelmoune authored
-
- 24 Mar, 2019 1 commit
-
-
Federico G. Schwindt authored
-
- 22 Mar, 2019 1 commit
-
-
Dridi Boukelmoune authored
This was actually done with a Coccinelle patch after finding plain free() calls out of tree: $ cat >free_obj.cocci <<EOF @@ expression obj, objp, magic; @@ ( TAKE_OBJ_NOTNULL(obj, objp, magic); | CAST_OBJ_NOTNULL(obj, objp, magic); | CHECK_OBJ_NOTNULL(obj, magic); | CHECK_OBJ_ORNULL(obj, magic); | CHECK_OBJ(obj, magic); ) ... - free(obj); + FREE_OBJ(obj); $ spatch --dir . --in-place --sp-file free_obj.cocci Asking again, could we consider keeping Coccinelle patches around?
-
- 21 Mar, 2019 2 commits
-
-
Prince Rachit Sinha authored
-
Poul-Henning Kamp authored
Submitted by: @tnn2 Fixes #2954
-
- 20 Mar, 2019 2 commits
-
-
Nils Goroll authored
Fixes #2953
-
Nils Goroll authored
on ppc64 fedora, the thread_pool_stack minimum is 128kb due to sysconf(_SC_THREAD_STACK_MIN) = 131072 It does not harm the test to use a larger stacksize, so we adjust it to this requirement for consistency and simplicity
-
- 18 Mar, 2019 1 commit
-
-
Dridi Boukelmoune authored
It is now safe to assume that a constructor is always called with proper values or never called to begin with, and as such to panic if it's not the case. Bonus polish in the files I visited. Refs #2297
-
- 17 Mar, 2019 5 commits
-
-
Nils Goroll authored
-
Nils Goroll authored
-
Nils Goroll authored
not even in vmod_debug because it sets the only catflap example for the time being.
-
Nils Goroll authored
-
Federico G. Schwindt authored
-
- 16 Mar, 2019 2 commits
-
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
- 15 Mar, 2019 12 commits
-
-
Pål Hermunn Johansen authored
-
Pål Hermunn Johansen authored
Happy new year!
-
Pål Hermunn Johansen authored
-
Pål Hermunn Johansen authored
-
Nils Goroll authored
This reverts commit de3e581e. tests/saintmode/test04.vtc from varnish-modules revealed that there may be use cases where it is implied that vcl_backend_error will leave a ttl=0 object and the sale object will remain in place. This can be resolved by: - return(abandon) for these cases or - making the HSH_Kill conditional on bo->fetch_objcore->ttl > 0 but I already has concerns regarding the impact of this change and have them even more now. We need time to ponder about the consequences and a documented inefficiency is better than unexpected behaviour in a release.
-
Nils Goroll authored
Our stack space canary in v00004.vtc fell off the twig on fedora rawhide i686 Thank you to @ingvarha for testing, reporting and all your support overall!
-
Poul-Henning Kamp authored
-
Nils Goroll authored
Fixes #2946 in the sense that we want to treat backend synth like any other object and kill the stale object it replaces. The two HSH_Kill calls could also be subsumed in vbf_fetch_thread(), but after an irc discussion, phk decided that he wanted to aim for even more consolidation later. The test checks that we remove the stale_oc, but not when abandoning the bereq.
-
Poul-Henning Kamp authored
-
Poul-Henning Kamp authored
-
Geoff Simmons authored
-
Federico G. Schwindt authored
-
- 14 Mar, 2019 12 commits
-
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Geoff Simmons authored
-
Dridi Boukelmoune authored
I'm keeping that information in both the changes and upgrading documents to increase the chances that people will notice it. The imprecise "changes" statement predated the decision to drop Python 2 entirely and was spotted by Geoff.
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
-
Federico G. Schwindt authored
Reported by coverity.
-
Federico G. Schwindt authored
-